【Hackathon 第三期 No.4】 为 Paddle 新增 cummax API #45073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
1. change "ops::CummaxGradMaker" to "ops::CummaxGradOpMaker" 2. change "ops::CumOp" to "ops::CummaxOp"
|
完全可以借鉴 cumsum 和 logcumsumexp 这两个API的实现，我的 forward kernel 几乎就是直接借鉴过来，只改了一行代码，其中 forward CPU kernel 似乎是没问题， 但是 forward GPU kernel 有点问题。 backward kernel 应该就需要自己理解后，完全自己写了。 |
|
|
||
| if in_dygraph_mode(): | ||
| if axis is None: axis = -1 | ||
| return _C_ops.final_state_cummax(x, axis, flatten, False, False) |
There was a problem hiding this comment.
你好，Paddle底层过了改造，同意去掉了final_state_前缀。麻烦把这里的final_state_删掉吧~
There was a problem hiding this comment.
@OccupyMars2025
改造的PR见 ：#45306
开发文档的改造见：#45306 (comment)
Comment on lines
+3146
to
+3148
| return _C_ops.cummax(x, 'flatten', flatten) | ||
| else: | ||
| return _C_ops.cummax(x, 'axis', axis, 'flatten', flatten) |
There was a problem hiding this comment.
你好，Paddle底层过了改造，以后老动态图API不再放在_C_ops，而是放在_legacy_C_ops下。辛苦这里也修改一下吧。
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
为 Paddle 新增 cummax API