-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Eager] delete final state pre-name #45306
[Eager] delete final state pre-name #45306
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM for change paddle_build.bat |
和 @jeff41404 讨论后
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… del_final_state_pre_name2
2ebf43e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… del_final_state_pre_name2
c0ecbe1
PR types
Others
PR changes
Others
Describe
动态图早期,为了区分中间态和最终态,将最终态PythonC暴露的API叫做final_state_xxx,这非常不利于其它开发者理解。
本PR删除所有final_state的前缀。
本PR之前,python端调用PythonC暴露的API的方法是:
本PR之后:
此外,后续还计划对调用_legacy_C_ops的PR加approve拦截。原则上避免新的_legacy_C_ops调用。