Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Remove unreachable _legacy_C_ops branches #61771

Merged
merged 11 commits into from
Feb 18, 2024
Merged

[Cleanup] Remove unreachable _legacy_C_ops branches #61771

merged 11 commits into from
Feb 18, 2024

Conversation

DrRyanHuang
Copy link
Member

@DrRyanHuang DrRyanHuang commented Feb 15, 2024 •
edited
Loading

PR types

Others

PR changes

Others

Description

@SigureMo :
_legacy_C_ops 是老动态图的

@SigureMo :
或者说新老动态图的过渡中间态

@SigureMo :
新老动态图都是将近两年前的事了，这个早就可以删了

@SigureMo :
你看看，你这永远跑不到下面的 legacy 啊

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Feb 15, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

SigureMo
SigureMo reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python/paddle/nn/functional/vision.py:312:5 还有一个，也一起删一下吧

@SigureMo SigureMo changed the title rm legacy_C_op in python/paddle/nn/functional/pooling.py [Cleanup] Remove unreachable _legacy_C_ops branches Feb 15, 2024
SigureMo
SigureMo approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo SigureMo self-assigned this Feb 18, 2024
@SigureMo SigureMo merged commit 8a5f035 into PaddlePaddle:develop Feb 18, 2024
30 checks passed
@DrRyanHuang DrRyanHuang deleted the rm_legacy branch February 19, 2024 01:41
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees

@SigureMo SigureMo

Labels
HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrRyanHuang @SigureMo @luotao1