Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify size op impl #45808

Merged
merged 4 commits into from
Sep 9, 2022
Merged

Conversation

chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Sep 6, 2022

PR types

Function optimization

PR changes

OPs

Describe

Simplify size op impl

paddle.numel() 即 size op返回的size是一个scalar值,应该始终放在CPU上,避免不必要的copy

@paddle-bot
Copy link

paddle-bot bot commented Sep 6, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@LiYuRio LiYuRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for collective.py

@chenwhql chenwhql merged commit c252b1d into PaddlePaddle:develop Sep 9, 2022
chenwhql added a commit that referenced this pull request Sep 16, 2022
chenwhql added a commit to chenwhql/Paddle that referenced this pull request Sep 18, 2022
chenwhql added a commit that referenced this pull request Sep 19, 2022
phlrain pushed a commit that referenced this pull request Sep 19, 2022
JiabinYang added a commit that referenced this pull request Sep 20, 2022
* fix linspace error in amp

* fix log

* fix amp error

* Revert "Simplify size op impl (#45808)"

This reverts commit c252b1d.

* fix_seg

* fix detection

Co-authored-by: Chen Weihang <sunny_cwh@163.com>
JiabinYang added a commit to JiabinYang/Paddle that referenced this pull request Sep 20, 2022
* fix linspace error in amp

* fix log

* fix amp error

* Revert "Simplify size op impl (PaddlePaddle#45808)"

This reverts commit c252b1d.

* fix_seg

* fix detection

Co-authored-by: Chen Weihang <sunny_cwh@163.com>
phlrain pushed a commit that referenced this pull request Sep 20, 2022
* [Eager] Fix ocr (#46124)

* fix linspace error in amp

* fix log

* fix amp error

* fix ocr error which caused by amp

* add more check

* rename dtype ns

* [Eager Bug fix]Fix Detection (#46147)

* fix linspace error in amp

* fix log

* fix amp error

* Revert "Simplify size op impl (#45808)"

This reverts commit c252b1d.

* fix_seg

* fix detection

Co-authored-by: Chen Weihang <sunny_cwh@163.com>

Co-authored-by: Chen Weihang <sunny_cwh@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants