Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Simplify size op impl" #46123

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Revert "Simplify size op impl" #46123

merged 1 commit into from
Sep 19, 2022

Conversation

chenwhql
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

Revert "Simplify size op impl"

@paddle-bot
Copy link

paddle-bot bot commented Sep 16, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

JiabinYang
JiabinYang approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlrain phlrain self-requested a review September 16, 2022 11:49
ZzSean
ZzSean approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for CI-OP-Benchmark

ZzSean
ZzSean approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for CI-OP-Benchmark

@chenwhql chenwhql merged commit d963e2e into develop Sep 19, 2022
@luotao1 luotao1 deleted the revert-45808-phi/simplify_size_op branch September 22, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZzSean ZzSean ZzSean approved these changes

@tianshuo78520a tianshuo78520a tianshuo78520a approved these changes

@JiabinYang JiabinYang JiabinYang approved these changes

@phlrain phlrain Awaiting requested review from phlrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenwhql @JiabinYang @tianshuo78520a @ZzSean