-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Dy2Static ] Fix bugs when select inputs meeting different shape or undefined-var #45916
Merged
2742195759
merged 2 commits into
PaddlePaddle:develop
from
2742195759:dy2static-fixbug-cond-shape
Sep 14, 2022
Merged
[ Dy2Static ] Fix bugs when select inputs meeting different shape or undefined-var #45916
2742195759
merged 2 commits into
PaddlePaddle:develop
from
2742195759:dy2static-fixbug-cond-shape
Sep 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. select_input_with_buildin_type directly return non-undefinedvar branch when meeting undefined var 2. the output shape of select_input is inferred from inputs.
2742195759
changed the title
[Dy2Static] Fix bugs when select inputs meeting different shape or undefined-var
[ Dy2Static ] Fix bugs when select inputs meeting different shape or undefined-var
Sep 9, 2022
Aurelius84
approved these changes
Sep 14, 2022
2742195759
added a commit
to 2742195759/Paddle
that referenced
this pull request
Sep 14, 2022
…undefined-var (PaddlePaddle#45916) * fix select_input with different shape errors: 1. select_input_with_buildin_type directly return non-undefinedvar branch when meeting undefined var 2. the output shape of select_input is inferred from inputs. * reverse the logic in select_input
2742195759
added a commit
to 2742195759/Paddle
that referenced
this pull request
Nov 2, 2022
…undefined-var (PaddlePaddle#45916) * fix select_input with different shape errors: 1. select_input_with_buildin_type directly return non-undefinedvar branch when meeting undefined var 2. the output shape of select_input is inferred from inputs. * reverse the logic in select_input
XiaoguangHu01
pushed a commit
that referenced
this pull request
Nov 4, 2022
* [ Dy2Static ] Fix bugs when select inputs meeting different shape or undefined-var (#45916) * fix select_input with different shape errors: 1. select_input_with_buildin_type directly return non-undefinedvar branch when meeting undefined var 2. the output shape of select_input is inferred from inputs. * reverse the logic in select_input * [warning] added warning message in cond block when one branch returns variable and another returns None (#46031) * [cherry-pick] Allow manaully set py_reader name in standalone executor (#45898) (#45931) * Allow manaully set py_reader name in standalone executor * [BugFix] while cond receives dict as input (#47299) * fix bugs while cond receives dict as input * add unittest * change flatten -> _is_sequence_except_dict * code format Co-authored-by: feifei-111 <wuzhanfei@baidu.com>
pangyoki
pushed a commit
to pangyoki/Paddle
that referenced
this pull request
Nov 4, 2022
…Paddle#47299 (PaddlePaddle#47610) * [ Dy2Static ] Fix bugs when select inputs meeting different shape or undefined-var (PaddlePaddle#45916) * fix select_input with different shape errors: 1. select_input_with_buildin_type directly return non-undefinedvar branch when meeting undefined var 2. the output shape of select_input is inferred from inputs. * reverse the logic in select_input * [warning] added warning message in cond block when one branch returns variable and another returns None (PaddlePaddle#46031) * [cherry-pick] Allow manaully set py_reader name in standalone executor (PaddlePaddle#45898) (PaddlePaddle#45931) * Allow manaully set py_reader name in standalone executor * [BugFix] while cond receives dict as input (PaddlePaddle#47299) * fix bugs while cond receives dict as input * add unittest * change flatten -> _is_sequence_except_dict * code format Co-authored-by: feifei-111 <wuzhanfei@baidu.com>
jzhang533
pushed a commit
that referenced
this pull request
Nov 7, 2022
…ompatible with installed cudnn version (#47673) * Cherry-pick PR47666, add cudnn error (#47666) * [CherryPick] Cherry pick #45916 #46031 #47299 (#47610) * [ Dy2Static ] Fix bugs when select inputs meeting different shape or undefined-var (#45916) * fix select_input with different shape errors: 1. select_input_with_buildin_type directly return non-undefinedvar branch when meeting undefined var 2. the output shape of select_input is inferred from inputs. * reverse the logic in select_input * [warning] added warning message in cond block when one branch returns variable and another returns None (#46031) * [cherry-pick] Allow manaully set py_reader name in standalone executor (#45898) (#45931) * Allow manaully set py_reader name in standalone executor * [BugFix] while cond receives dict as input (#47299) * fix bugs while cond receives dict as input * add unittest * change flatten -> _is_sequence_except_dict * code format Co-authored-by: feifei-111 <wuzhanfei@baidu.com> Co-authored-by: xiongkun <xiongkun03@baidu.com> Co-authored-by: feifei-111 <wuzhanfei@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
fix select_input with different shape errors: