Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] cond receives dict as input #47299

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

2742195759
Copy link
Contributor

PR types

Bug fixes

PR changes

APIs

Describe

fix bugs while cond receives dict as input

@paddle-bot
Copy link

paddle-bot bot commented Oct 24, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@0x45f 0x45f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2742195759 2742195759 merged commit 13a5f18 into PaddlePaddle:develop Oct 25, 2022
@2742195759 2742195759 changed the title [BugFix] while cond receives dict as input [BugFix] cond receives dict as input Nov 2, 2022
2742195759 added a commit to 2742195759/Paddle that referenced this pull request Nov 2, 2022
* fix bugs while cond receives dict as input

* add unittest

* change flatten -> _is_sequence_except_dict
XiaoguangHu01 pushed a commit that referenced this pull request Nov 4, 2022
* [ Dy2Static ] Fix bugs when select inputs meeting different shape or undefined-var (#45916)

* fix select_input with different shape errors:
1. select_input_with_buildin_type directly return non-undefinedvar branch when meeting undefined var
2. the output shape of select_input is inferred from inputs.

* reverse the logic in select_input

* [warning] added warning message in cond block when one branch returns variable and another returns None (#46031)

* [cherry-pick] Allow manaully set py_reader name in standalone executor (#45898) (#45931)

* Allow manaully set py_reader name in standalone executor

* [BugFix] while cond receives dict as input (#47299)

* fix bugs while cond receives dict as input

* add unittest

* change flatten -> _is_sequence_except_dict

* code format

Co-authored-by: feifei-111 <wuzhanfei@baidu.com>
pangyoki pushed a commit to pangyoki/Paddle that referenced this pull request Nov 4, 2022
…Paddle#47299  (PaddlePaddle#47610)

* [ Dy2Static ] Fix bugs when select inputs meeting different shape or undefined-var (PaddlePaddle#45916)

* fix select_input with different shape errors:
1. select_input_with_buildin_type directly return non-undefinedvar branch when meeting undefined var
2. the output shape of select_input is inferred from inputs.

* reverse the logic in select_input

* [warning] added warning message in cond block when one branch returns variable and another returns None (PaddlePaddle#46031)

* [cherry-pick] Allow manaully set py_reader name in standalone executor (PaddlePaddle#45898) (PaddlePaddle#45931)

* Allow manaully set py_reader name in standalone executor

* [BugFix] while cond receives dict as input (PaddlePaddle#47299)

* fix bugs while cond receives dict as input

* add unittest

* change flatten -> _is_sequence_except_dict

* code format

Co-authored-by: feifei-111 <wuzhanfei@baidu.com>
jzhang533 pushed a commit that referenced this pull request Nov 7, 2022
…ompatible with installed cudnn version (#47673)

* Cherry-pick PR47666, add cudnn error (#47666)

* [CherryPick] Cherry pick #45916 #46031 #47299  (#47610)

* [ Dy2Static ] Fix bugs when select inputs meeting different shape or undefined-var (#45916)

* fix select_input with different shape errors:
1. select_input_with_buildin_type directly return non-undefinedvar branch when meeting undefined var
2. the output shape of select_input is inferred from inputs.

* reverse the logic in select_input

* [warning] added warning message in cond block when one branch returns variable and another returns None (#46031)

* [cherry-pick] Allow manaully set py_reader name in standalone executor (#45898) (#45931)

* Allow manaully set py_reader name in standalone executor

* [BugFix] while cond receives dict as input (#47299)

* fix bugs while cond receives dict as input

* add unittest

* change flatten -> _is_sequence_except_dict

* code format

Co-authored-by: feifei-111 <wuzhanfei@baidu.com>

Co-authored-by: xiongkun <xiongkun03@baidu.com>
Co-authored-by: feifei-111 <wuzhanfei@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants