[PHI] Migrate sgd and stack oneDNN kernels #46374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
@chenwhql Please review |
YuanRisheng
approved these changes
Sep 22, 2022
chenwhql
approved these changes
Sep 22, 2022
YuanRisheng
reviewed
Sep 22, 2022
There was a problem hiding this comment.
@piotrekobi To prevent maintenance of duplicate codes, axpy_handler.h/cc should be deleted in Fluid，may be you need do it in next pr, thanks.
|
@YuanRisheng I left it there for now because paddle/fluid/operators/math/selected_rows_functor.cc uses it and I had to modify the PHI version slightly so it's not compatible with it. Once selected_rows_functor.cc gets deleted or migrated axpy_handler.h/cc can be deleted from fluid. |
umiswing
pushed a commit
to umiswing/Paddle
that referenced
this pull request
Sep 28, 2022
* Convert slice+grad oneDNN fluid kernels to PHI * Change mutable_data to Alloc * Refactor licences
Silv3S
pushed a commit
to Silv3S/Paddle
that referenced
this pull request
Oct 3, 2022
* Convert slice+grad oneDNN fluid kernels to PHI * Change mutable_data to Alloc * Refactor licences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Migrates the following oneDNN operator fluid kernels to PHI: