Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all communication operations from collective #47255

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Move all communication operations from collective #47255

merged 1 commit into from
Nov 4, 2022

Conversation

LiYuRio
Copy link
Contributor

@LiYuRio LiYuRio commented Oct 21, 2022 •
edited by ForFishes
Loading

PR types

Others

PR changes

Others

Describe

Move all communicated operations from collective.py to communication. Make the communication API under distributed reuse the new implementation under stream module.

  • ReduceOp
  • all_reduce
  • alltoall
  • alltoall_single
  • broadcast
  • reduce
  • send
  • scatter
  • isend
  • recv
  • irecv
  • batch_isend_irecv
  • P2POp
  • reduce_scatter
  • is_initialized
  • destroy_process_group
  • get_group
  • all_gather
  • all_gather_object
  • wait
  • barrier
  • new_group

Other remain APIs will be moved in next PRs.

@paddle-bot
Copy link

paddle-bot bot commented Oct 21, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@LiYuRio LiYuRio force-pushed the dev_refine_collective branch 2 times, most recently from 46ed784 to 613835f Compare October 24, 2022 03:11
@LiYuRio LiYuRio force-pushed the dev_refine_collective branch 2 times, most recently from 218ddde to 989e162 Compare October 24, 2022 07:11
@LiYuRio LiYuRio force-pushed the dev_refine_collective branch 22 times, most recently from ec958f4 to 7f485b7 Compare October 31, 2022 03:39
@LiYuRio LiYuRio force-pushed the dev_refine_collective branch 17 times, most recently from 2694de8 to a321aff Compare November 3, 2022 06:05
sljlp
sljlp approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@sljlp sljlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HermitSun
HermitSun approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@HermitSun HermitSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jzhang533
jzhang533 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sljlp sljlp merged commit 99504cb into PaddlePaddle:develop Nov 4, 2022
@HermitSun HermitSun mentioned this pull request Nov 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzhang533 jzhang533 jzhang533 approved these changes

@sljlp sljlp sljlp approved these changes

@HermitSun HermitSun HermitSun approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LiYuRio @jzhang533 @sljlp @HermitSun @XiaoguangHu01