Move collective communication all_gather from collective.py
#48339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
LiYuRio
reviewed
Nov 25, 2022
| @@ -24,6 +25,8 @@ | |||
|
|
|||
| __all__ = [ | |||
| "ReduceOp", | |||
| "all_gather", | |||
| "all_gather_object", | |||
There was a problem hiding this comment.
这个是官方公开的对外调用的接口形式不？
paddle.distributed.communication.all_gather()
There was a problem hiding this comment.
这里务必再提PR改一下，__all__只用来存放对外公开的API
There was a problem hiding this comment.
因为外层的__init__里使用了import *，暂时使用这种写法以避免引入额外的依赖。
后续pr中将会进行清理。
XiaoguangHu01
approved these changes
Nov 25, 2022
| @@ -24,6 +25,8 @@ | |||
|
|
|||
| __all__ = [ | |||
| "ReduceOp", | |||
| "all_gather", | |||
| "all_gather_object", | |||
There was a problem hiding this comment.
这里务必再提PR改一下，__all__只用来存放对外公开的API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
Move all communicated operations from collective.py to communication. Make the communication API under distributed reuse the new implementation under stream module.
Followed by #47255.