Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHI] Migrate matmul kernel #48162

Merged
merged 50 commits into from
Nov 29, 2022
Merged

Conversation

Silv3S
Copy link
Member

@Silv3S Silv3S commented Nov 18, 2022

PR types

Others

PR changes

Others

Describe

  • migrate matmul_v2 kernel to PHI,
  • add missing ExtraAttr for fuse with scale.

@Silv3S Silv3S marked this pull request as ready for review November 22, 2022 21:58
@Silv3S
Copy link
Member Author

Silv3S commented Nov 26, 2022

For failing PR-CI-Coverage I checked unit tests and PHI matmul kernel is called properly

YuanRisheng
YuanRisheng previously approved these changes Nov 28, 2022
@Silv3S
Copy link
Member Author

Silv3S commented Nov 29, 2022

@YuanRisheng could you manually mark CI-Coverage as successful and merge this kernel? There is problem with not enough % of coverage, but all tests are passing

@YuanRisheng YuanRisheng merged commit f41ccbd into PaddlePaddle:develop Nov 29, 2022
@Silv3S Silv3S deleted the phi_matmul_kernel branch November 29, 2022 08:42
lxsbupt pushed a commit to lxsbupt/Paddle that referenced this pull request Dec 17, 2022
* cleanup unused code

* unify is_int8 is_bfloat16

* Simplify matmul_v2 FWD kernel

* remove RunKernel methods

* remove import namespace

* remove headers

* clean fluid/phi cross imports

* remove fluid axpy_handler

* delete fluid methods

* activations

* OneDNNMemDesc

* MKLDNNFormatForSize

* MatchShapeToLayout

* MKLDNNMemoryFormat

* MKLDNNFormat

* ReorderMKLDNNHandler

* to_void_cast

* review suggestions

* interpolate

* remove fluid depedency

* init

* ExecuteMatMulV2

* rm fluid kernel

* matmul_grad

* remove mutable_data

* mul_grad

* matmul fwd

* add extra attr

* temp disable passes

* re-enable passes

* workaround for matmul+act

* fix for matmul+eltwise_add

* fix typo

* merge bugfix PaddlePaddle#48364

* remove merge conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers Intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants