Remove py36 code in .py files #48426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Nov 27, 2022
SigureMo
previously approved these changes
Nov 28, 2022
There was a problem hiding this comment.
2022-11-28 18:20:24 ************************************************************************************
2022-11-28 18:20:24 Your PR code style check failed.
2022-11-28 18:20:24 Please install pre-commit locally and set up git hook scripts:
2022-11-28 18:20:24
2022-11-28 18:20:24 pip install pre-commit==2.17.0
2022-11-28 18:20:24 pre-commit install
2022-11-28 18:20:24
2022-11-28 18:20:24 Then, run pre-commit to check codestyle issues in your PR:
2022-11-28 18:20:24
2022-11-28 18:20:24 pre-commit run --files python/paddle/distributed/spawn.py python/paddle/fluid/tests/unittests/collective/fleet/test_parallel_dygraph_mnist.py python/paddle/fluid/tests/unittests/collective/fleet/test_parallel_dygraph_no_sync.py python/paddle/fluid/tests/unittests/collective/fleet/test_parallel_dygraph_se_resnext.py python/paddle/fluid/tests/unittests/collective/fleet/test_parallel_dygraph_sparse_embedding.py python/paddle/fluid/tests/unittests/collective/fleet/test_parallel_dygraph_sparse_embedding_over_height.py python/paddle/fluid/tests/unittests/collective/fleet/test_parallel_dygraph_unused_variables.py python/paddle/fluid/tests/unittests/test_paddle_save_load.py python/paddle/fluid/tests/unittests/test_static_save_load.py python/paddle/hapi/progressbar.py python/paddle/incubate/multiprocessing/reductions.py python/paddle/vision/datasets/folder.py tools/dockerfile/build_scripts/ssl-check.py
2022-11-28 18:20:24
2022-11-28 18:20:24 For more information, please refer to our codestyle check guide:
2022-11-28 18:20:24 https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/git_guides/codestyle_check_guide_cn.html
2022-11-28 18:20:24 ************************************************************************************
可以按照提示解决下 codestyle 问题，主要是 Black、Flake8 F401 问题（pylint 不用管），都可自动修复，运行命令后直接 commit 应该就可以解决了
其余 LGTM～
可以考虑之后一个 PR 解决 sys.version 相关的一些分支
好滴 现在pre-commit在pylint阶段会报错，不知道你这边是不是这样 |
pylint 暂时不用管，目前有很多存量，问题详情见 #47821 CI 里显示貌似还有两个多余的 import 没有删除？ |
done |
luotao1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
清理框架代码中Python 3.5/3.6 相关逻辑分支
related works：