-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeStyle][py36] remove sys.version branch for py36 #48540
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
还有一些通过 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
小小的代码风格建议~
其余都没有问题~
我瞅了下,貌似只有像这种 macOS + Python3 的判断了 Paddle/python/paddle/fluid/io.py Lines 1998 to 1999 in ca55293
这里可以考虑移除下 |
这块不移除是可以的,但ast3.py里还有一些需要移除,比如 Paddle/python/paddle/utils/gast/ast3.py Line 153 in ca55293
|
这是 gast(https://github.com/serge-sans-paille/gast )的文件,是一个引入到 Paddle 内部的第三方库,考虑到未来可能和 gast 原 repo 同步版本(为了兼容更高版本的 Python 语法 / AST),因此这个第三方库没有进行各种代码风格的监控,这在上一次 review 中也提了下 #48426 (comment) |
Got it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
@gsq7474741 PR-CI-Mac-Python3 可以尝试 re-run 一下,这个问题这两天我的其他 PR 也遇到了,re-run 之后可能会通过 |
test_audio_backend 单测已豁免 |
PR types
Others
PR changes
Others
Describe
移除通过 sys.version 判断python版本(小于3.7)的逻辑,
related works