[CodeStyle][py36] remove deprecated warnings for py36 #48639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Dec 1, 2022
| # The following line set DeprecationWarning to show once, which is expected to work in python 3.2 -> 3.6 | ||
| # However, doing this could introduce one samll side effect, i.e., the DeprecationWarning which is not issued by @deprecated. | ||
| # The side effect is acceptable, and we will find better way to do this if we could. | ||
| warnings.simplefilter('default', DeprecationWarning) |
There was a problem hiding this comment.
麻烦 @zhiqiu 确认下现在仅支持 Python3.7+ 的情况下这里是否安全移除～
There was a problem hiding this comment.
修改后，deprecated warning还能正常显示吗？如果可以就没有问题哈。
There was a problem hiding this comment.
因为有下面 51 行的存在，deprecated warning 本来就是无法正常显示的
def decorator(func):
# TODO(zhiqiu): temporally disable the warnings
return func
...但是移除 51 行的 return func 的话，无论是否删除 32 行，deprecated warning 都可以正常显示
There was a problem hiding this comment.
@luotao1 我觉得这个 PR 是没问题啦，关于是否解除 51 行 disable 掉的 deprecated warning 应该与本 PR 无关，至少是否解除本 PR 修改前后的行为都是一致的，应该是可以考虑合入啦～
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Since python 3.2, DeprecationWarning is ignored by default, and since python 3.7, it is once again shown by default when triggered directly by code in
__main__. See details: https://docs.python.org/3/library/warnings.html#default-warning-filter移除显式启用DeprecationWarning
related works