Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][py36] remove deprecated warnings for py36 #48639

Merged
merged 1 commit into from
Dec 5, 2022
Merged

[CodeStyle][py36] remove deprecated warnings for py36 #48639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions python/paddle/utils/deprecated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,6 @@

__all__ = []

# NOTE(zhiqiu): Since python 3.2, DeprecationWarning is ignored by default,
# and since python 3.7, it is once again shown by default when triggered directly by code in __main__.
# See details: https://docs.python.org/3/library/warnings.html#default-warning-filter
# The following line set DeprecationWarning to show once, which is expected to work in python 3.2 -> 3.6
# However, doing this could introduce one samll side effect, i.e., the DeprecationWarning which is not issued by @deprecated.
# The side effect is acceptable, and we will find better way to do this if we could.
warnings.simplefilter('default', DeprecationWarning)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

麻烦 @zhiqiu 确认下现在仅支持 Python3.7+ 的情况下这里是否安全移除～

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改后，deprecated warning还能正常显示吗？如果可以就没有问题哈。

Copy link
Member

@SigureMo SigureMo Dec 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为有下面 51 行的存在，deprecated warning 本来就是无法正常显示的

    def decorator(func):
        # TODO(zhiqiu): temporally disable the warnings
        return func
        ...

但是移除 51 行的 return func 的话，无论是否删除 32 行，deprecated warning 都可以正常显示

Copy link
Member

@SigureMo SigureMo Dec 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luotao1 我觉得这个 PR 是没问题啦，关于是否解除 51 行 disable 掉的 deprecated warning 应该与本 PR 无关，至少是否解除本 PR 修改前后的行为都是一致的，应该是可以考虑合入啦～



def deprecated(update_to="", since="", reason="", level=0):
"""Decorate a function to signify its deprecation.
Expand Down