Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang-tidy] enable cppcoreguidelines-pro-type-reinterpret-cast check #55630

Closed
wants to merge 1 commit into from

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Jul 23, 2023

@GreatV
Copy link
Contributor

GreatV commented Jul 23, 2023

@gouzil 我发现那个任务表格有点旧,pytorch 也没有启用 cppcoreguidelines-pro-type-reinterpret-cast 应该不需要启用检查。我重新更新一下表格。

@GreatV
Copy link
Contributor

GreatV commented Jul 23, 2023

可以先处理任务表格里和.clang-tidy里面都列出来的

@paddle-bot paddle-bot bot added the contributor External developers label Jul 23, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 24, 2023
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jul 31, 2023

Sorry to inform you that 79ab798's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@paddle-bot
Copy link

paddle-bot bot commented Aug 1, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@gouzil gouzil deleted the nolint_reinterpret_cast branch August 1, 2023 16:12
@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants