-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
赛题四:在飞桨框架中引入 clang-tidy Tracking Issue #54073
Labels
PFCC
Paddle Framework Contributor Club,https://github.com/PaddlePaddle/community/tree/master/pfcc
Comments
paddle-bot
bot
added
the
PFCC
Paddle Framework Contributor Club,https://github.com/PaddlePaddle/community/tree/master/pfcc
label
May 23, 2023
认领 |
认领26 |
This was referenced Jul 18, 2023
建议先把非CINN目录的代码格式修复完+CI监控上,再考虑CINN目录。原因如下: @GreatV @zhangbo9674 |
|
@luotao1 好的,收到。 |
认领6 |
@zrr1999 @RedContritio @gouzil 任务表格更新了一下,有些任务已经没有了,麻烦重新领取一下任务。 旧任务表格如下所示:
|
@BeingGod 我重新扫描了一下,发现 |
@GreatV 好的 |
认领 13,16 |
This was referenced Jul 27, 2023
This was referenced Feb 5, 2024
[clang-tidy] NO.17 enable cppcoreguidelines-explicit-virtual-functions,modernize-use-override
#61714
Merged
This was referenced Feb 12, 2024
This was referenced Feb 27, 2024
This was referenced May 7, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PFCC
Paddle Framework Contributor Club,https://github.com/PaddlePaddle/community/tree/master/pfcc
一、 项目说明
用于跟踪 clang-tidy代码风格检查工具的引入 并记录该计划下各个子任务的计划和进度。
二、 主要工作
📓 操作指南
(以
readability-container-size-empty
为例)-DCMAKE_EXPORT_COMPILE_COMMANDS=ON
在
.clang-tidy
中移除-readability-container-size-empty
的前缀-
clang-tidy
,并根据clang-tidy
提示修改代码也可以直接运行clang-tidy并行检查工具:
整体进展 (39/94)
1. 存量修复相关
旧任务表格如下所示(旧任务进展 55/94):按完成时间顺序,排名不分先后: @GreatV (4) @BeingGod (4) @gouzil (19) @ccsuzzh (5) @enkilee (13) @xiaoyewww (6) @SigureMo (3) @RedContritio (1)
2. 增量拦截相关
.pre-commit-config.yaml
在添加clang-tidy
检查项clang-tidy
,开发者便于手动执行检查tools/codestyle/clang-tidy.py
即可clang-tidy
工具同步到release分支clang-tidy
同步到CI镜像中,PR-CI-Build
中打开CI, 避免重复安装下载3. 移除pre-commit中的
-WnoXXX
(.pre-commit-config.yaml)paddle/cinn
重新加入 clang-tidy pre-commit 扫描路径,并确保打开的检查项能够通过
The text was updated successfully, but these errors were encountered: