Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang-tidy] NO.3 enable modernize-redundant-void-arg check #55652

Merged
merged 1 commit into from
Jul 26, 2023
Merged

[clang-tidy] NO.3 enable modernize-redundant-void-arg check #55652

merged 1 commit into from
Jul 26, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Jul 24, 2023 •
edited
Loading

@GreatV GreatV mentioned this pull request Jul 24, 2023
Open
@paddle-bot paddle-bot bot added the contributor External developers label Jul 24, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 25, 2023
@GreatV
Copy link
Contributor

GreatV commented Jul 25, 2023

还有一些

/paddle/paddle/fluid/distributed/collective/reducer.cc:495:28: error: redundant void argument list in lambda expression [modernize-redundant-void-arg,-warnings-as-errors]
    auto reduce_hook = [=](void) -> void {

/paddle/paddle/fluid/pybind/eager_functions.cc
/paddle/paddle/fluid/pybind/eager_op_function.cc

zhangbo9674
zhangbo9674 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 12fb18d into PaddlePaddle:develop Jul 26, 2023
@luotao1
Copy link
Contributor

luotao1 commented Jul 26, 2023

还有一些提在下一个PR中 @gouzil

@gouzil gouzil mentioned this pull request Jul 27, 2023
Merged
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
@gouzil @wz1qqx
add modernize-redundant-void-arg check (PaddlePaddle#55652)
08996c3
@gouzil gouzil deleted the clang_tidy_enable_check_modernize_redundant_void_arg branch August 1, 2023 16:15
@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Aug 7, 2023
jinjidejinmuyan pushed a commit to jinjidejinmuyan/Paddle that referenced this pull request Aug 30, 2023
@gouzil
add modernize-redundant-void-arg check (PaddlePaddle#55652)
22cd8dc
@gouzil gouzil mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

Assignees

@luotao1 luotao1

@GreatV GreatV

@zhangbo9674 zhangbo9674

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gouzil @GreatV @luotao1 @zhangbo9674