Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang-tidy][task 61] enable hicpp-exception-baseclass and fix existing errors #55847

Merged

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Jul 31, 2023

PR types

Others

PR changes

Others

Description

apt install clang-tidy-10

python ./tools/codestyle/clang-tidy.py -p=build -j=10 -extra-arg=-Wno-unknown-warning-option \
-extra-arg=-Wno-pessimizing-move \
-extra-arg=-Wno-braced-scalar-init \
-extra-arg=-Wno-deprecated-copy \
-extra-arg=-Wno-dangling-gsl \
-extra-arg=-Wno-final-dtor-non-final-class \
-extra-arg=-Wno-implicit-int-float-conversion \
-extra-arg=-Wno-inconsistent-missing-override \
-extra-arg=-Wno-infinite-recursion \
-extra-arg=-Wno-mismatched-tags  \
-extra-arg=-Wno-self-assign \
-extra-arg=-Wno-sign-compare \
-extra-arg=-Wno-sometimes-uninitialized \
-extra-arg=-Wno-tautological-overlap-compare \
-extra-arg=-Wno-unused-const-variable \
-extra-arg=-Wno-unused-lambda-capture \
-extra-arg=-Wno-unused-private-field \
-extra-arg=-Wno-unused-value \
-extra-arg=-Wno-unused-variable  \
-extra-arg=-Wno-overloaded-virtual  \
-extra-arg=-Wno-defaulted-function-deleted  \
-extra-arg=-Wno-delete-non-abstract-non-virtual-dtor  \
-extra-arg=-Wno-return-type-c-linkage -j=10  > clang-tidy.log  2>&1

grep "hicpp-exception-baseclass" clang-tidy.log

PCard-66962

@paddle-bot
Copy link

paddle-bot bot commented Jul 31, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo SigureMo requested a review from zhangbo9674 August 1, 2023 01:21
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Aug 8, 2023

Sorry to inform you that f7ff086's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

zhangbo9674
zhangbo9674 previously approved these changes Aug 29, 2023
@luotao1
Copy link
Contributor

luotao1 commented Aug 29, 2023

请解决下冲突

@luotao1 luotao1 merged commit 31a9688 into PaddlePaddle:develop Aug 30, 2023
@SigureMo SigureMo deleted the clang-tidy/hicpp-exception-baseclass branch August 30, 2023 03:51
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
…ting errors (PaddlePaddle#55847)

* [clang-tidy] enable `hicpp-exception-baseclass` and fix existing errors

* config

* update error format to pass the ci check (at least 20 chars)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants