-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clang-tidy][task 5] enable modernize-make-shared
and fix existing linter errors
#55807
[clang-tidy][task 5] enable modernize-make-shared
and fix existing linter errors
#55807
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
# which contains "complex128" as data. "complex128" is memory-aligned manually. But make_shared | ||
# request MEMALIGN for allocation (Maybe). | ||
# See https://stackoverflow.com/questions/31228656/how-can-shared-ptr-disrupt-alignment | ||
# and https://github.com/MRtrix3/mrtrix3/issues/957 | ||
node_construction_str = f"{indent}auto grad_node = std::shared_ptr<{grad_node_name}>(new {grad_node_name}({num_backward_inputs}, {num_backward_outputs}));" | ||
node_assignment_str = f"{indent}grad_node = std::shared_ptr<{grad_node_name}>(new {grad_node_name}({num_backward_inputs}, {num_backward_outputs}));" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加 NOLINT 原因见上面的 NOTE,因此相关的 GradNode 均 NOLINT 了,包括手写的和自动生成的
Sorry to inform you that a65c472's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
请解决下冲突 |
PR types
Others
PR changes
Others
Description
800 多个基本全是自动生成的(我这里统计是 847 个),因此修改模板后剩下的不多了,另外已经启用的
modernize-make-unique
和modernize-redundant-void-arg
明显有一些存量的,会在 pre-commit 时候阻塞 commit(需要加--no-verify
才能过),相关 PR 应该尽快合入PCard-66962