[clang-tidy] NO.8 enable cppcoreguidelines-narrowing-conversions. step:1
#56218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
gouzil
commented
Aug 13, 2023
| @@ -97,7 +98,8 @@ size_t CpuMinChunkSize() { | |||
| size_t CUDAPinnedMaxAllocSize() { | |||
There was a problem hiding this comment.
CUDA的部分是不是应该放到paddle/phi/backends/gpu/cuda/cuda_info.cc这个文件下比较合适
…idelines_narrowing_conversions
zhangbo9674
previously approved these changes
Aug 14, 2023
luotao1
reviewed
Aug 15, 2023
.clang-tidy
Outdated
| @@ -156,7 +156,7 @@ bugprone-unused-raii, | |||
| -cppcoreguidelines-c-copy-assignment-signature, | |||
| -cppcoreguidelines-explicit-virtual-functions, | |||
| -cppcoreguidelines-init-variables, | |||
| -cppcoreguidelines-narrowing-conversions, | |||
| cppcoreguidelines-narrowing-conversions, | |||
gouzil
changed the title
cppcoreguidelines-narrowing-conversionscppcoreguidelines-narrowing-conversions. step:1
|
Sorry to inform you that 85c4c4c's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
…coreguidelines_narrowing_conversions
…coreguidelines_narrowing_conversions # Conflicts: # paddle/phi/backends/device_manager.cc
|
@luotao1 需要豁免覆盖率 |
zhangbo9674
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
当前进度
784/2477相关链接: