Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang-tidy] NO.22 fix modernize-make-unique #55764

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

BeingGod
Copy link
Contributor

PR types

Others

PR changes

Others

Description

fix clang-tidy modernize-make-unique

@paddle-bot
Copy link

paddle-bot bot commented Jul 27, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 27, 2023
@BeingGod
Copy link
Contributor Author

之前分支误删了,麻烦帮我把之前这个PR#55668 关联到这里 @GreatV

@BeingGod BeingGod force-pushed the modernize_make_unique branch 2 times, most recently from 36596a7 to 27de679 Compare July 29, 2023 05:51
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 31, 2023
@BeingGod BeingGod force-pushed the modernize_make_unique branch 3 times, most recently from 2864a67 to 50d61a2 Compare August 2, 2023 15:47
@BeingGod BeingGod force-pushed the modernize_make_unique branch from 50d61a2 to 29d5a4e Compare August 3, 2023 07:41
@BeingGod
Copy link
Contributor Author

BeingGod commented Aug 4, 2023

可以帮忙review一下吗? @zhangbo9674

@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Aug 7, 2023
@BeingGod BeingGod changed the title [clang-tidy] fix modernize-make-unique [clang-tidy] NO.22 fix modernize-make-unique Aug 7, 2023
zhangbo9674
zhangbo9674 previously approved these changes Aug 7, 2023
@luotao1
Copy link
Contributor

luotao1 commented Aug 7, 2023

请解决下冲突

Verified

This commit was signed with the committer’s verified signature.
suemto suem
@BeingGod BeingGod closed this Aug 8, 2023
@BeingGod BeingGod deleted the modernize_make_unique branch August 8, 2023 13:22
@BeingGod BeingGod restored the modernize_make_unique branch August 8, 2023 13:22
@paddle-bot
Copy link

paddle-bot bot commented Aug 8, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@GreatV GreatV reopened this Aug 8, 2023
@luotao1 luotao1 merged commit 9f04f2a into PaddlePaddle:develop Aug 9, 2023
@BeingGod BeingGod deleted the modernize_make_unique branch August 23, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants