Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API Enhancement] No.1 support the any number of times in paddle.diff [used AI Studio] #56681

Merged
merged 5 commits into from
Aug 28, 2023
Merged

[API Enhancement] No.1 support the any number of times in paddle.diff [used AI Studio] #56681

merged 5 commits into from
Aug 28, 2023

Conversation

XavierZXY
Copy link
Contributor

@XavierZXY XavierZXY commented Aug 26, 2023 •
edited
Loading

PR types

Function optimization

PR changes

APIs

Description

In paddle.diff, the number of times to recursively compute the difference support any number.
飞桨框架API易用性提升开源任务 #55883

@paddle-bot
Copy link

paddle-bot bot commented Aug 26, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Aug 26, 2023
@XavierZXY XavierZXY changed the title [API Enhancement] No.1 support the any number of times in paddle.diff [API Enhancement] No.1 support the any number of times in paddle.diff [used AI Studio] Aug 26, 2023
@XavierZXY
Copy link
Contributor Author

@luotao1 PTAL

@XavierZXY XavierZXY mentioned this pull request Aug 28, 2023
Closed
andyjiang1116
andyjiang1116 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@andyjiang1116 andyjiang1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 39e8b02 into PaddlePaddle:develop Aug 28, 2023
@luotao1
Copy link
Contributor

luotao1 commented Aug 28, 2023

hi, @XavierZXY

  • 非常感谢你对飞桨框架的贡献，我们正在运营一个PFCC组织，会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献，详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣，请发送邮件至 ext_paddle_oss@baidu.com，我们会邀请你加入~

andyjiang1116
andyjiang1116 reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@andyjiang1116 andyjiang1116 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XavierZXY 麻烦顺便改下英文文档和中文文档里关于仅支持n=1的描述吧 英文文档，中文文档

@luotao1
Copy link
Contributor

luotao1 commented Aug 28, 2023

文档里参数n的介绍，也要去掉仅支持n=1的描述

lxd-cumt pushed a commit to lxd-cumt/Paddle that referenced this pull request Aug 28, 2023
@XavierZXY @lxd-cumt
[API Enhancement] No.1 support the any number of times in paddle.diff…
c274162 
… [used AI Studio] (PaddlePaddle#56681)

* Fix: The number of times to recursively compute the difference supports any number

* Fix: use pre-commit to format code
@XavierZXY
Copy link
Contributor Author

好的

@XavierZXY XavierZXY deleted the diff-improve branch August 28, 2023 14:03
This was referenced Aug 29, 2023
Merged
Merged
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
@XavierZXY @BeingGod
[API Enhancement] No.1 support the any number of times in paddle.diff…
e56e202 
… [used AI Studio] (PaddlePaddle#56681)

* Fix: The number of times to recursively compute the difference supports any number

* Fix: use pre-commit to format code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyjiang1116 andyjiang1116 andyjiang1116 approved these changes

@luotao1 luotao1 luotao1 approved these changes

Assignees

@luotao1 luotao1

@zhwesky2010 zhwesky2010

@andyjiang1116 andyjiang1116

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XavierZXY @luotao1 @andyjiang1116 @zhwesky2010