Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【pir】part2 of Expand optest #57478

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

xiaoguoguo626807
Copy link
Contributor

PR types

Bug fixes

PR changes

others

Description

pcard-67164
修复可变attribute为vector of opreslut的python-c 生成代码, 支持opreslut, vectorofopreslut + stack , vector<int64_t> + fill_int_array

@paddle-bot
Copy link

paddle-bot bot commented Sep 19, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BUILTIN_COMBINE_OP_TEMPLATE = """
{name} = paddle::dialect::builtin_combine({name}_tmp);
BUILTIN_STACK_OP_TEMPLATE = """
{name} = paddle::dialect::stack({name}_tmp, 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个0 是什么?axis?

Suggested change
{name} = paddle::dialect::stack({name}_tmp, 0);
{name} = paddle::dialect::stack({name}_tmp, /*axis=*/0);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiaoguoguo626807 xiaoguoguo626807 merged commit e30b274 into PaddlePaddle:develop Sep 20, 2023
27 checks passed
Copy link
Contributor Author

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment 修复#57520

@xiaoguoguo626807 xiaoguoguo626807 deleted the expand1 branch September 20, 2023 03:20
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
* expand first

* expand first

* modify expand special case

* code style
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* expand first

* expand first

* modify expand special case

* code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants