【pir】Modify comment of pr57478 and pr56873 #57520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
xiaoguoguo626807
changed the title
This was referenced Sep 20, 2023
Aurelius84
reviewed
Sep 20, 2023
| std::vector<pir::OpResult> add_n_grad(std::vector<pir::Value> inputs, | ||
| pir::Value out_grad) { | ||
| std::vector<pir::OpResult> add_n_grad(const std::vector<pir::Value>& inputs, | ||
| const pir::Value& out_grad) { |
There was a problem hiding this comment.
单值这里其实是不需要的，之前大家讨论的规范是，类似Value、Result 因为是Pimpl，可以直接传值，但std::vector这些容器不行。
Aurelius84
previously approved these changes
Sep 20, 2023
Aurelius84
approved these changes
Sep 21, 2023
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* tmp * reply comment * code style
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
* tmp * reply comment * code style
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* tmp * reply comment * code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
pcard-67164
回复split, expand 修复pr#56873 #57478中的comment：