[DimExpr] DimExpr support print #60146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
lanxianghit
reviewed
Dec 21, 2023
| @@ -239,4 +240,8 @@ class ValueShape { | |||
|
|
|||
| using ValueShapeDimExprs = ValueShape<DimExpr>; | |||
There was a problem hiding this comment.
这个地方不该应再叫ValueShape了吧？
| DimExprBuilder builder{nullptr}; | ||
| DimExpr sym0 = DimExpr("S0"); | ||
| DimExpr sym1 = DimExpr("S1"); | ||
| ASSERT_EQ((ToTxtString(sym0 + sym1)), "Add(S0, S1)"); |
There was a problem hiding this comment.
函数名是否有点冗长，ToString就可以吧，或者PIR里其实都用的是Print，我觉得可以保持一致
There was a problem hiding this comment.
有道理，本函数的返回值是 std::string，因此改成了 ToString
DimExpr 已经重载了 operator<< 函数，因此打印时还可以直接调用 VLOG，例如 VLOG(1)<<dim_expr
tianshuo78520a
approved these changes
Dec 27, 2023
Wanglongzhi2001
pushed a commit
to Wanglongzhi2001/Paddle
that referenced
this pull request
Jan 7, 2024
* DimExpr support print * ToTxtString * Fix ASSERT_EQ bug * Fix typo * Fix unittest * ToTxtString->ToString * Fix windows CI * ShapeOrData cannot use IR_API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
pcard-76996
[DimExpr] DimExpr support print
See
test/cpp/pir/shape_dialect/symbol_dim_expr_test.ccfor the print result.