Use DimExpr and change InferSymbolicShapeInterface #60371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhangbopd
force-pushed
the
symbolic_infer
branch
from
634161b
to
4b1d120
Compare
zhangbopd
force-pushed
the
symbolic_infer
branch
from
4b1d120
to
aced1f7
Compare
lanxianghit
reviewed
Dec 27, 2023
| pir::OpResult res = op->result(0); | ||
| std::string res_id = pir::GetValueId(&res); | ||
| shape_analysis->value_id_to_shapeordata_[res_id] = | ||
| shape_analysis->value_id_to_shapeordata_[operand_source_id]; |
There was a problem hiding this comment.
正式代码里最好不要直接操作成员变量了，需要使用封装接口操作
lanxianghit
reviewed
Dec 27, 2023
| // Value output_shape = | ||
| // builder.Build<shape::FromElementsOp>(shape_values).result(0); | ||
| // reified_return_shapes.push_back(output_shape); | ||
| bool ShapeSrOpInferSymbolicShape( |
There was a problem hiding this comment.
Shape"Sr"Op 中间的Sr是什么含义？
There was a problem hiding this comment.
selected_rows 版本的算子，ShapeSrOp 和 ShapeSrOp 共用了一个 yaml 配置
|
|
||
| symbol::ShapeOrDataDimExprs shape_data; | ||
| shape_data = shape_analysis->value_id_to_shapeordata_[operand_source_id]; | ||
| shape_analysis->value_id_to_shapeordata_[res_id] = shape_data; |
There was a problem hiding this comment.
#60146 这个PR合入之后，可以增加一些调试信息输出，便于以后调试使用
There was a problem hiding this comment.
好的，这个PR里 重写了 DebugPrintOpInfo，目前也支持 符号和 int_64 两种类型的 Dim_Expr 打印，后续会改用新的接口
zhangbopd
changed the title
lanxianghit
previously approved these changes
Dec 27, 2023
zyfncg
reviewed
Dec 27, 2023
Comment on lines
+46
to
+50
| std::string operand_source_id = pir::GetValueId(&operand_source); | ||
| pir::OpResult res = op->result(0); | ||
| std::string res_id = pir::GetValueId(&res); | ||
| shape_analysis->value_id_to_shapeordata_[res_id] = | ||
| shape_analysis->value_id_to_shapeordata_[operand_source_id]; |
There was a problem hiding this comment.
value可以直接用作map的key吗？看着用value id会多一些处理
| symbol::ShapeOrDataDimExprs shape_data; | ||
|
|
||
| shape_data = shape_analysis->value_id_to_shapeordata_[operand_source_1_id]; | ||
| shape_analysis->value_id_to_shapeordata_[res_id] = shape_data; |
There was a problem hiding this comment.
这里应该后面要用到宏宇PR的一个接口，下个PR改，这里data应该还是空的
| auto res = op->result(0); | ||
| auto res_id = pir::GetValueId(&res); | ||
|
|
||
| shape_analysis->value_id_to_shapeordata_[res_id] = value_shape; |
zyfncg
approved these changes
Dec 27, 2023
lanxianghit
approved these changes
Dec 28, 2023
Wanglongzhi2001
pushed a commit
to Wanglongzhi2001/Paddle
that referenced
this pull request
Jan 7, 2024
* Use DimExpr and change InferSymbolicShapeInterface * static infer lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-67164
Use DimExpr and change InferSymbolicShapeInterface
Note : Windows static library（both CPU and GPU）over the limit, so no longer create_static_lib, and cc_library is dummy