Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typing] Fix undefined names in example code #65429

Conversation

SigureMo
Copy link
Member

PR Category

User Experience

PR Types

Bug fixes

Description

根据 #65397 mypy 全量检查的问题,修复示例代码中部分名字未定义的问题(在此之前,可能导致用户 copy 的代码跑不了)

PCard-66972

Copy link

paddle-bot bot commented Jun 24, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo SigureMo changed the title [Typing] Fix undefined names in example code Fix undefined names in example code Jun 25, 2024
@SigureMo SigureMo changed the title Fix undefined names in example code [Typing] Fix undefined names in example code Jun 25, 2024
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit 534decd into PaddlePaddle:develop Jun 25, 2024
32 of 34 checks passed
@SigureMo SigureMo deleted the typing/fix-undefind-names-in-example-code branch June 25, 2024 02:09
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants