[Typing] 修改一些错误的类型标注以及示例代码 #65452
Merged
[Typing] 修改一些错误的类型标注以及示例代码 #65452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megemini
requested review from
XiaoguangHu01,
zhiqiu,
Xreki,
qili93 and
Aurelius84
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
非必要的情况下，PR 最好不要超过 20 个文件啊 😂 |
嗯嗯 ～ 改着改着一看都这么多了 ～～～ 🤣 打算后面尽量每天都能修改一部分 #65397 发现的错误 ～ 小步快跑吧 ～ |
SigureMo
reviewed
Jun 25, 2024
| >>> if dist.get_rank() == 0: | ||
| ... data = paddle.to_tensor([1, 2, 3]) | ||
| ... dist.gather(data, gather_list, dst=0) | ||
| >>> else: | ||
| ... data = paddle.to_tensor([4, 5, 6]) | ||
| ... dist.gather(data1, gather_list, dst=0) | ||
| ... dist.gather(data, gather_list, dst=0) |
There was a problem hiding this comment.
？ 没冲突啊 ～ 我再 merge 一下 ～ 刚好把这个 pr 的文件数量删减一下 ～
| @@ -149,7 +149,7 @@ def sample(self, shape): | |||
| >>> import paddle | |||
| >>> from paddle.distribution import Bernoulli | |||
|
|
|||
| >>> rv = Bernoulli(paddle.full((1), 0.3)) | |||
| >>> rv = Bernoulli(paddle.full([1,], 0.3)) | |||
python/paddle/nn/functional/loss.py
Outdated
| @@ -337,7 +337,8 @@ def npair_loss(anchor, positive, labels, l2_reg=0.002): | |||
| .. code-block:: python | |||
|
|
|||
| >>> import paddle | |||
| >>> DATATYPE = "float32" | |||
| >>> from paddle._typing import DTypeLike | |||
| >>> DATATYPE: DTypeLike = "float32" | |||
There was a problem hiding this comment.
这个我是不是也改了？和另一个 PR 冲突了吧，revert 掉吧
python/paddle/amp/debugging.py
Outdated
| @@ -87,7 +88,7 @@ def check_layer_numerics(func): | |||
| ... # return 1/x * self._w + self._b open it you will see the error log | |||
| ... return x @ self._w + self._b | |||
| ... | |||
| >>> dtype = 'float32' | |||
| >>> dtype: DTypeLike = 'float32' | |||
There was a problem hiding this comment.
Suggested change
| >>> dtype: DTypeLike = 'float32' | |
| >>> dtype: Literal["float32"] = 'float32' |
目前都是这样改的
|
20 个以上文件需要大佬 review，合并周期会长很多…… 一般 PR 不要超过 10 个文件吧…… |
嗯 我拆分一下 ～ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Others
PR Types
Others
Description
__iter__应该返回Iterator[str]list[Tensor]list[object]关联 PR #65008 #65397
@SigureMo