feature/print op #6799
Merged
feature/print op #6799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
reviewed
Dec 21, 2017
paddle/operators/CMakeLists.txt
Outdated
| @@ -260,6 +261,7 @@ op_library(recurrent_op SRCS recurrent_op.cc DEPS executor) | |||
| # FIXME(typhoonzero): save/load depends lodtensor serialization functions | |||
| op_library(save_op DEPS lod_tensor) | |||
| op_library(load_op DEPS lod_tensor) | |||
| op_library(print_op SRCS print_op.cc DEPS lod_tensor) | |||
There was a problem hiding this comment.
what kind of operator need to declare in this CMakeLists?
jacquesqiao
reviewed
Dec 21, 2017
| attrs={ | ||
| 'first_n': first_n, | ||
| 'summarize': summarize, | ||
| 'message': message if message else "", |
There was a problem hiding this comment.
can use
'message': message or ""
qingqing01
reviewed
Dec 21, 2017
|
|
||
| Args: | ||
| input: A Tensor to print. | ||
| summarize: Print this number of elements in the tensor. |
There was a problem hiding this comment.
Should tell the user what will be happened when summarize=-1.
| print_tensor_name: Print the tensor name. | ||
| print_tensor_type: Print the tensor type. | ||
| print_tensor_shape: Print the tensor shape. | ||
| print_tensor_lod: Print the tensor lod. |
There was a problem hiding this comment.
| input: A Tensor to print. | ||
| summarize: Print this number of elements in the tensor. | ||
| message: A string message to print as a prefix. | ||
| first_n: Only log `first_n` number of times. |
There was a problem hiding this comment.
Only log
first_nnumber of times
这个注释不是特别明白~
There was a problem hiding this comment.
只有前 frist_n 次forward时会打log @qingqing01
| print_tensor_shape=True, | ||
| print_tensor_lod=True): | ||
| ''' | ||
| Creates a print op that will print when a tensor is accessed. |
There was a problem hiding this comment.
Make sure that the layer comments are same as the convention defined in #6806
jacquesqiao
reviewed
Dec 28, 2017
paddle/operators/print_op.cc
Outdated
|
|
||
| template <typename T> | ||
| void Display() { | ||
| auto* d = (T*)data; |
jacquesqiao
reviewed
Jan 11, 2018
| PADDLE_ENFORCE(!Inputs("input").empty(), "input should be set"); | ||
| auto* input_var = scope.FindVar(Input("input")); | ||
| PADDLE_ENFORCE_NOT_NULL(input_var); | ||
| auto& tensor = input_var->Get<framework::LoDTensor>(); |
There was a problem hiding this comment.
enforce(is_cpu_place(tensor.place()))
pkuyym
reviewed
Jan 11, 2018
paddle/operators/print_op.cc
Outdated
| auto& tensor = input_var->Get<framework::LoDTensor>(); | ||
|
|
||
| // TODO(ChunweiYan) support GPU | ||
| PADDLE_ENFORCE(framework::is_cpu_place(tensor.place())); |
pkuyym
reviewed
Jan 11, 2018
| import paddle.v2.fluid.layers as pd | ||
|
|
||
|
|
||
| class TestSumOp(unittest.TestCase): |
jacquesqiao
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #6788