Add split selected rows op #7604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Jan 17, 2018
| : OpProtoAndCheckerMaker(proto, op_checker) { | ||
| AddInput("X", "The input SelectedRows."); | ||
| AddOutput("Out", "The outputs of input SelectedRows.").AsDuplicable(); | ||
| AddAttr<std::vector<int>>("rows_section", "Rows section for output.") |
There was a problem hiding this comment.
rows_section => `rows_sections
| AddOutput("Out", "The outputs of input SelectedRows.").AsDuplicable(); | ||
| AddAttr<std::vector<int>>("rows_section", "Rows section for output.") | ||
| .SetDefault(std::vector<int>({})); | ||
| AddAttr<std::vector<int>>("height_section", |
|
|
||
| AddComment(R"DOC( | ||
| Split a SelectedRows with a specified rows section. | ||
| You could set height_section for specified the height for each output. |
There was a problem hiding this comment.
height_sections is only needed when need to split the dims of the original tensor.
| } | ||
| }; | ||
|
|
||
| class SplitSelectedRowsGradMaker : public framework::SingleGradOpDescMaker { |
There was a problem hiding this comment.
I didn't see a grad kernel implementation, did you missed that?
There was a problem hiding this comment.
We reuse sum op as the grad op, and I will add the unit test for it.
There was a problem hiding this comment.
Do you need to register the sum kernel as the grad kernel?
There was a problem hiding this comment.
Maybe don't need, just inherit framework::SingleGradOpDescMaker , we can use another Operator as the grad op.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #7558