Add keras mnist demo #238
Merged
Add keras mnist demo #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daming-lu
requested review from
Superjomn,
cs2be,
varunarora,
nickyfantasy,
jetfuel and
jacquesqiao
Superjomn
reviewed
Feb 1, 2018
demo/keras/TUTORIAL_CN.md
Outdated
| <img width="70%" src="https://github.com/daming-lu/large_files/blob/master/keras_demo_figs/keras_scalar.png?raw=true" /> | ||
| </p> | ||
|
|
||
| 训练过后的第一，第二层卷积权重图的如下： |
There was a problem hiding this comment.
you can use an image component to visualize training image. Both the two images lacks information.
cs2be
reviewed
Feb 1, 2018
| image1.finish_sampling() | ||
|
|
||
| train_step += 1 | ||
| self.losses.append(logs.get('loss')) |
There was a problem hiding this comment.
removed as it is not very related to this demo.
demo/keras/TUTORIAL_CN.md
Outdated
| # create a scalar component called 'scalars/' | ||
| scalar_keras_train_loss = logger.scalar( | ||
| "scalars/scalar_keras_train_loss") | ||
| image0 = logger.image("images/image0", 1) |
There was a problem hiding this comment.
why do we need to prefix with "images/"? Isn't this graph only going to show up in images section?
There was a problem hiding this comment.
'images/' is showing that we can group metrics by namespace, which will be implemented in the future.
demo/keras/TUTORIAL_CN.md
Outdated
| "scalars/scalar_keras_train_loss") | ||
| image0 = logger.image("images/image0", 1) | ||
| image1 = logger.image("images/image1", 1) | ||
| histogram0 = logger.histogram("histogram/histogram0", num_buckets=50) |
There was a problem hiding this comment.
Same here, why do we need "histogram/" prefix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.