【PFCC算子性能优化】添加selu算子性能优化文档 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
谢谢，已收到！
|
JamesLim-sy
reviewed
Jul 8, 2022
| | 1 | [8, 1024, 3073] |0.4630 | | ||
| | 2 | [5100, 38506] | 3.6001| | ||
| | 3 | [300, 100, 128] |0.073 | | ||
|
|
There was a problem hiding this comment.
这部分感觉可以罗列一下 paddle目前的性能状态，以及对应的case配置信息
|
为什么close了呀？ |
那个性能测试有一些出入，考虑重新测试后再PR。 |
可以不关闭PR，再提一个commit即可 |
|
我重新commit了，请问必须该PR通过后才能提交算子代码到Paddle仓库吗。 |
JamesLim-sy
reviewed
Jul 14, 2022
| |---|---|---| | ||
| | 1 | 理清Paddle中OP设计思路，同类产品中最佳设计方案 | 2022-07-06 | | ||
| | 2 | 完成开发文档设计 | 2022-07-07 | | ||
| | 3 | 完成代码开发工作，并通过线程CI测试 | 2022-07-10 | |
There was a problem hiding this comment.
文档整体我觉得OK了，目前就是这个时间规划应该需要结合当前的进展改一下哈。
修复了case序号上的一个小问题，抱歉！ |
这个PR没通过也可以提交算子代码到Paddle仓库，但review会先等RFC通过后再review Paddle仓库的PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.