Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing GOAWAY Error on a couple datasources #507

Merged
merged 1 commit into from
May 20, 2022

Conversation

stmcallister
Copy link
Contributor

Hopefully fixes #476.

After talking with PagerDuty engineering we concluded it would be best to remove the check for the 429 error code response and relax the resource.Retry to retry on all errors returned by the API. I implemented this on only the two data sources mentioned in Issue 476 to see if it remedies the issue. Will roll out to other data sources as the need arises.

Test results.

TF_ACC=1 go test -run "TestAccDataSourcePagerDutyEscalationPolicy" ./pagerduty -v -timeout 120m
=== RUN   TestAccDataSourcePagerDutyEscalationPolicy_Basic
--- PASS: TestAccDataSourcePagerDutyEscalationPolicy_Basic (8.61s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   9.183s

TF_ACC=1 go test -run "TestAccDataSourcePagerDutyRuleset" ./pagerduty -v -timeout 120m 
=== RUN   TestAccDataSourcePagerDutyRuleset_Basic
--- PASS: TestAccDataSourcePagerDutyRuleset_Basic (3.96s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   4.310s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform often fails with "http2: server sent GOAWAY and closed the connection"
2 participants