Addressing GOAWAY Error on a couple datasources #507
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #476.
After talking with PagerDuty engineering we concluded it would be best to remove the check for the 429 error code response and relax the
resource.Retry
to retry on all errors returned by the API. I implemented this on only the two data sources mentioned in Issue 476 to see if it remedies the issue. Will roll out to other data sources as the need arises.Test results.