Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing GOAWAY error on pagerduty_service_dependency #653

Conversation

imjaroiswebdev
Copy link
Contributor

Closes #620

Following with the adoption of #507 workaround, I'm proceeding to remove the check for http error for retries, because it has been showing to be successful to mitigate the GOAWAY issues with the API.

Test results...

make testacc TESTARGS="-run TestAccPagerDutyBusinessServiceDependency"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyBusinessServiceDependency -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
=== RUN   TestAccPagerDutyBusinessServiceDependency_Basic
--- PASS: TestAccPagerDutyBusinessServiceDependency_Basic (15.56s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   16.177s

Particularly interested in removing the check for 429 errors
@imjaroiswebdev
Copy link
Contributor Author

Proceeding to immediately merge this as being a patch already applied to others resources facing the same issue, which is being progressively applied as the need arises.

@imjaroiswebdev imjaroiswebdev merged commit 3d0e720 into PagerDuty:master Mar 10, 2023
@NargiT
Copy link
Contributor

NargiT commented Mar 12, 2023

great ! I will integrate these changes monday and let you know ! Thank you

@NargiT
Copy link
Contributor

NargiT commented Mar 13, 2023

no more issues since we upgraded ! 🎉 🎉 🎉 🎉 🍾 🍾 🍾 🍾

@imjaroiswebdev
Copy link
Contributor Author

@NargiT thank you so much for letting know how it is going 🎉 💪🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants