Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade Terraform version for examples, fix links for diagrams and sources for modules #23

Merged
merged 8 commits into from
Mar 6, 2024

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Mar 5, 2024

Description

PR:

  • upgrades Terraform version for examples
  • changes links for diagrams
  • fix sources for modules
  • update Terraform version for modules loadbalancer, virtual_machine, vnet and vnet_peering
  • update AzureRM provider for modules

Motivation and Context

#3

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech sebastianczech requested a review from a team as a code owner March 5, 2024 14:39
@sebastianczech sebastianczech changed the base branch from main to refactor-modules March 5, 2024 14:40
@sebastianczech sebastianczech changed the title chore: Upgrade Terraform version for examples chore: Upgrade Terraform version for examples, links for diagrams and sources for modules Mar 5, 2024
@sebastianczech sebastianczech changed the title chore: Upgrade Terraform version for examples, links for diagrams and sources for modules chore: Upgrade Terraform version for examples, fix links for diagrams and sources for modules Mar 5, 2024
@acelebanski
Copy link
Contributor

Can you check TF and provider versions in modules as well? I see that loadbalancer is still 1.3 for instance.

@acelebanski acelebanski added the refactor Related to code refactoring label Mar 5, 2024
@sebastianczech
Copy link
Contributor Author

thanks @acelebanski - I updated min TF version for modules loadbalancer, virtual_machine, vnet and vnet_peering

@acelebanski
Copy link
Contributor

thanks @acelebanski - I updated min TF version for modules loadbalancer, virtual_machine, vnet and vnet_peering

Hi @sebastianczech, sorry I should have mentioned that earlier - I believe we shouldn't bump the TF version for virtual_machine module since it's for some legacy use-cases only. Migara asked not to refactor it (only thing I did in the latest PR is some descriptions changes etc. but no changes to the logic).

@sebastianczech
Copy link
Contributor Author

@acelebanski you are right, sorry for the mistake. I restored modules/virtual_machine from branch refactor-modules.

@acelebanski
Copy link
Contributor

One more thing, we also bumped AzureRM provider in some modules to "~> 3.80". Most of them is still on "~> 3.25". Can we bump that everywhere too?

@sebastianczech
Copy link
Contributor Author

Done 👍

Copy link
Contributor

@acelebanski acelebanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 👍

modules/natgw/.header.md Show resolved Hide resolved
examples/standalone_vmseries/README.md Outdated Show resolved Hide resolved
modules/vmss/.header.md Outdated Show resolved Hide resolved
@acelebanski acelebanski merged commit 18545ec into refactor-modules Mar 6, 2024
@acelebanski acelebanski deleted the upgrade-tf-version-for-examples branch March 6, 2024 14:42
@acelebanski acelebanski mentioned this pull request Mar 6, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Related to code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants