Change name from inverse to inv
#12
Assignees
Labels
enhancement
New feature or request
Comments
Samuele-Colombo
added a commit
that referenced
this issue
May 25, 2021
Samuele-Colombo
added a commit
that referenced
this issue
May 26, 2021
* Add Pigments * Rename pigments.jl to materials.jl * Add convenienc function for Pigment functor * Add BRDF and DiffuseBRDF * Fix overflowing * Fix CheckeredPigment constructor * Add Pigment tests * Fix inheritance in DiffuseBRDF * Define Material * Fix Material definition * Fix DiffuseBRDF default pigment * Fix Pigment subtyping * Change inclusion order to be able to use materials in shapes * As previous commit but for tests * Add needed exports * Add materials to Shape and HitRecord Also changed methods and tests accordingly * Fix user utils according to the previous changes * Fix "Change name from 'inverse' to 'inv'" #12 * update .gitignore to ignore .mp4 * Fix Sphere uv coordinates * Add ray_intersection to World * Fix naming convention for fire_all_rays * Fix Checkered_Pigment * Implement Renderers and reorganize user_utils * Update raytracer_cli * update video_demo * Uncomment needed constructor * Remove testing renderer * Fix limit case handling * Solve possible type mismatch * Fix old test to account for modifications * Add test_renderers * Add test for ray_intersection(::Ray, ::World) * Change special behavior for Spheres and tests * Last tweaks Co-authored-by: Paolo Galli <Paolo97Gll@users.noreply.github.com> Co-authored-by: Paolo Galli <Paolo97Gll@users.noreply.github.com>
|
Should be already implemented by @Samuele-Colombo in #17 , can we close the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I suggest to change the name of the method defined here from
inversetoinvto be coherent with the methodinvused in typeBase.Matrix.The text was updated successfully, but these errors were encountered: