Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(Sprint Poker): Error in ParabolScopingSearchResultItem #7943

Closed
Dschoordsch opened this issue Mar 27, 2023 · 15 comments
Closed

Bug(Sprint Poker): Error in ParabolScopingSearchResultItem #7943

Dschoordsch opened this issue Mar 27, 2023 · 15 comments
Assignees
Labels

Comments

@Dschoordsch
Copy link
Contributor

Dschoordsch commented Mar 27, 2023

https://parabol.sentry.io/issues/3402262694/?referrer=github_plugin

TypeError: Cannot destructure property 'id' of 'u' as it is undefined.
  at Ft (./packages/client/components/ParabolScopingSearchResultItem.tsx:78:14)
  at Set.forEach (<anonymous>)
...
(31 additional frame(s) were not displayed)

How to reproduce

  • Create a Sprint Poker meeting
  • add parabol tasks
  • advance the meeting
  • delete one of the tasks (the task itself from the task dashboard by removing its content)
  • go back to the sprint meeting scoping session
  • press the new task button
@Dschoordsch Dschoordsch added bug p1 Needs to be addressed fast. Such an issue significantly impacts the majority of users labels Mar 27, 2023
@Dschoordsch
Copy link
Contributor Author

2.2k events, 355 users, thus this should be a p1

@Dschoordsch
Copy link
Contributor Author

Sentry issue: ACTION-PRODUCTION-E0T

@Dschoordsch
Copy link
Contributor Author

Sentry issue: ACTION-PRODUCTION-DWZ

@Dschoordsch
Copy link
Contributor Author

Sentry issue: ACTION-PRODUCTION-DWY

@Dschoordsch
Copy link
Contributor Author

Linked additional issues which have different backtrace but appear in the same area and timespan thus probably have the same root cause.

@igorlesnenko
Copy link
Contributor

Just clicking New Task in the Parabol tab straight from the beginning does not work too
image

@Dschoordsch
Copy link
Contributor Author

Dschoordsch commented Apr 5, 2023

Yes. I discussed this yesterday with Matt. It's an issue resulting from adding the optimistic task to the edges of the task search result. Omitting the optimistic task would work, but Matt also suggested rearranging the GraphQL fragments, because James recently found out that something similar happened because of @plural items nested in a fragment.

@gcrickman
Copy link

A user 🔒 writes:

I'm unable to create a parabol task from a sprint poker meeting. I got this error:

TypeError: Cannot read properties of undefined (reading 'node')
at ParabolScopingSelectAllTasks.tsx:44:52
at Array.map (<anonymous>)
at Lt (ParabolScopingSelectAllTasks.tsx:44:25)
at aa (react-dom.production.min.js:157:137)
at Za (react-dom.production.min.js:180:154)
at Ws (react-dom.production.min.js:269:343)
at kl (react-dom.production.min.js:250:347)
at xl (react-dom.production.min.js:250:278)
at wl (react-dom.production.min.js:250:138)
at yl (react-dom.production.min.js:243:163)
at react-dom.production.min.js:123:115
at t.unstable_runWithPriority (scheduler.production.min.js:18:343)
at Bi (react-dom.production.min.js:122:325)
at Wi (react-dom.production.min.js:123:61)
at Ki (react-dom.production.min.js:122:428)
at hl (react-dom.production.min.js:237:203)
at ka (react-dom.production.min.js:170:408)
at v (useFragmentNode.js:62:5)
at FragmentResource.js:498:9
at t._updateSubscription (RelayStoreSubscriptions.js:172:7)
at RelayStoreSubscriptions.js:114:26
at Set.forEach (<anonymous>)
at t.updateSubscriptions (RelayStoreSubscriptions.js:113:25)
at t.notify (RelayModernStore.js:300:30)
at t.run (RelayPublishQueue.js:217:24)
at t._runPublishQueue (OperationExecutor.js:1388:61)
at t._handleNext (OperationExecutor.js:521:30)
at OperationExecutor.js:341:16
at e.exports (withDuration.js:26:16)
at OperationExecutor.js:340:28
at t._schedule (OperationExecutor.js:298:7)
at t._next (OperationExecutor.js:339:10)
at Object.next (OperationExecutor.js:156:17)
at Object.next (RelayObservable.js:534:20)
at t.default.dispatch (GQLTrebuchetClient.js:50:26)
at a.<anonymous> (GQLTrebuchetClient.js:11:18)
at s.emit (index.js:202:33)
at ws.onmessage (SocketTrebuchet.js:113:26)

@lilicaruso
Copy link

Enterprise User 🔒 followed up on resolution of this one.

@Dschoordsch
Copy link
Contributor Author

The workaround should be released by the end of this week.

@Dschoordsch Dschoordsch removed the p1 Needs to be addressed fast. Such an issue significantly impacts the majority of users label Apr 24, 2023
@Dschoordsch
Copy link
Contributor Author

Just removed the p1 label to not convey unnecessary urgency since the workaround solves it for now.

@jmtaber129
Copy link
Contributor

@Dschoordsch @BartoszJarocki can this be closed in favor of a task for the actual fix since the bandaid fix is merged?

@github-project-automation github-project-automation bot moved this from In Progress to Done in 🧁Product Squad Self Raise Apr 24, 2023
Dschoordsch added a commit that referenced this issue Jul 10, 2023
 #8472 only reverted part of the fix for #8451 which reintroduced
 #7943. Reverting fully until there is a fix for #8094.
Dschoordsch added a commit that referenced this issue Jul 10, 2023
#8472 only reverted part of the fix for #8451 which reintroduced
 #7943. Reverting fully until there is a fix for #8094.
@Dschoordsch
Copy link
Contributor Author

Sentry issue: ACTION-PRODUCTION-EWT

@Dschoordsch
Copy link
Contributor Author

Sentry issue: ACTION-PRODUCTION-EWS

@Dschoordsch
Copy link
Contributor Author

Reappeared due to a partial revert of the fix in #8472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Status: ✅Done
Development

No branches or pull requests

5 participants