feat: refactor feature flags #10234

nickoferrall · 2024-09-16T18:00:50Z

Fix #10099

This PR refactors feature flags from the array of enums to the new table approach.

The parent PRs added the new feature flag tables and mutations. Here I'm updating all of the references.

This PR can't be merged until we migrate old necessary feature flags over to the new tables, see: #10248

I'll also create a subsequent PR to notify the team via cron job when a feature flag is expiring: #10249.

To test

Add a feature flag with the addFeatureFlag mutation
Apply a feature flag to a user or org with applyFeatureFlag
See that the client reads the feature flag as expected

github-actions · 2024-09-16T18:01:17Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-09-17T15:02:08Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

…eature-flag-refactor

github-actions · 2024-09-17T15:22:35Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-09-17T15:47:22Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

nickoferrall · 2024-09-17T15:55:50Z

Sorry the PR is so large! I tried to break it down by splitting it into a few PRs, but I don't think there's a good way to make this one smaller.

mattkrick · 2024-09-17T19:52:02Z

packages/server/dataloader/customLoaderMakers.ts

-// }
+export const featureFlagByOwnerId = (parent: RootDataLoader) => {
+  return new DataLoader<
+    {ownerId: string; ownerType: 'User' | 'Team' | 'Organization'; featureName: string},


ownerType looks like a footgun,
see convo here: #10184 (comment)

…eature-flag-refactor

github-actions · 2024-09-20T17:43:14Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-09-20T17:56:46Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

packages/client/components/ActivityLibrary/ActivityLibrary.tsx

github-actions · 2024-09-25T17:01:20Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

mattkrick · 2024-09-27T00:06:39Z

packages/client/components/RetroGroupPhase.tsx

-          featureFlags {
-            suggestGroups
-          }
+          hasSuggestGroupsFlag: featureFlag(featureName: "suggestGroups")


+1 nit on alias convention-- sometimes you have a suffix like publicTeamsEnabled, sometimes it's just the name of the feature aiTemplate and here we have a has prefix. no right or wrong, but always nice to set a convention for others to follow

Makes sense! I like the most explicit option of has[name]Flag, so I've updated all of them to follow that convention

...ges/client/modules/email/components/SummaryEmail/MeetingSummaryEmail/WholeMeetingSummary.tsx

packages/server/dataloader/customLoaderMakers.ts

packages/server/graphql/private/mutations/applyFeatureFlag.ts

mattkrick · 2024-09-27T00:36:05Z

packages/server/graphql/private/typeDefs/Mutation.graphql

+  """
+  Get all of the feature flags for a user, team, or org
+  """
+  getFeatureFlags(userId: ID, teamId: ID, orgId: ID): GetFeatureFlagPayload!


-1 i think you meant to put this under query instead of mutation?

What's the use case for this one again? I can't remember.
Is there a way to query all feature flags in the system, e.g. if I'm a sales person & i want to apply a feature flag but I can't remember the name of the flag, how would i query it?

Thanks, i've removed this and added getAllFeatureFlags as a private query so that a sales person can query it to see all of the feature flags. I'll add a Notion doc with instructions once this is merged

packages/server/graphql/public/typeDefs/FeatureFlagScope.graphql

github-actions · 2024-09-30T15:43:01Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-09-30T15:55:57Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions · 2024-09-30T17:50:17Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

mattkrick · 2024-10-01T17:57:27Z

packages/server/dataloader/customLoaderMakers.ts

+        .selectFrom('FeatureFlag')
+        .innerJoin('FeatureFlagOwner', 'FeatureFlag.id', 'FeatureFlagOwner.featureFlagId')
+        .where((eb) =>
+          eb.and([


+1 you could simplify this a little because FeatureFlag tells you what column to look in so you don't have to look in all 3 columns.

You also don't have to destructure the (featureName, ownerId) tuple. You could do something like:

WHERE ("featureName", CASE "FeatureFlag"."scope" WHEN 'User' THEN "FeatureFlagOwner"."userId" WHEN 'Team' THEN "FeatureFlagOwner"."teamId" WHEN 'Organization' THEN "FeatureFlagOwner"."orgId" END) in :keys;

This will execute as something like WHERE ("featureName", "userId") in (("insights", "user123"), ("insights", "user456")). That way you won't overfetch (albeit the overfetch is pretty minimal in this case)

mattkrick

Looks good! 1 little change on the SQL piece, other than that good to go!

github-actions · 2024-10-04T15:08:40Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

nickoferrall added 18 commits September 9, 2024 16:48

change featureFlagNew to featureFlag and replace org featureFlag

85db00a

check zoomTranscription flag works

92b0e8d

update org feature flags

a7bd7ed

refactor public teams flag

3fa2e08

add feature flag to org and team

333c456

refactor feature flags in client

2059d00

implement dataloader

93e9cb4

add featureFlag to team

e3adf02

update canAccessAISummary

8a74299

remove update org feature flag

4d64131

remove update feature flag public mutation

17adb2b

remove org and user feature flags

c2c1b22

remove featureFlag references

7eba48b

implement getFeatureFlags

4352f88

implement get feature flags

d682ab1

remove user and org feature flag enums

4b0d699

merge with master

2e335c7

fux setMeetingSettings merge conflict error

8a4d5ba

nickoferrall changed the base branch from master to feat/apply-new-feature-flag-mutation September 16, 2024 18:01

github-actions bot added the size/xl label Sep 16, 2024

nickoferrall changed the base branch from feat/apply-new-feature-flag-mutation to master September 16, 2024 18:01

update migration order

0a40b4d

nickoferrall changed the base branch from master to feat/apply-new-feature-flag-mutation September 17, 2024 15:08

Merge branch 'feat/apply-new-feature-flag-mutation' into feat/10099/f…

e0b2dd9

…eature-flag-refactor

fix featureName

dfbf469

nickoferrall marked this pull request as ready for review September 17, 2024 15:53

nickoferrall requested a review from mattkrick September 17, 2024 15:53

mattkrick mentioned this pull request Sep 17, 2024

feat: add feature flag tables #10184

Merged

mattkrick reviewed Sep 17, 2024

View reviewed changes

nickoferrall added 2 commits September 20, 2024 17:21

Merge branch 'feat/apply-new-feature-flag-mutation' into feat/10099/f…

cb532b8

…eature-flag-refactor

update featureFlag references to use scope

4b165c7

update addFeatureFlag to use scope

39fa9e8

nickoferrall requested a review from mattkrick September 23, 2024 14:06

mattkrick reviewed Sep 24, 2024

View reviewed changes

packages/client/components/ActivityLibrary/ActivityLibrary.tsx Outdated Show resolved Hide resolved

remove scope from gql featureFlag query

4cf3339

nickoferrall requested a review from mattkrick September 25, 2024 17:03

mattkrick reviewed Sep 27, 2024

View reviewed changes

nickoferrall added 3 commits September 30, 2024 14:50

fix ups - remove featureFlagScope graphql

2e696de

use aliases consistently

e4190c3

add getAllFeatureFlags private query

df431b4

remove scope from dataloader

03551b8

remove scope from dataloader calls

f5ee24c

nickoferrall requested a review from mattkrick September 30, 2024 18:00

mattkrick reviewed Oct 1, 2024

View reviewed changes

chore: migrate noaisummary flag (#10293)

509f3a3

nickoferrall merged commit 6cc5887 into feat/apply-new-feature-flag-mutation Oct 4, 2024
7 checks passed

nickoferrall deleted the feat/10099/feature-flag-refactor branch October 4, 2024 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: refactor feature flags #10234

feat: refactor feature flags #10234

nickoferrall commented Sep 16, 2024 •

edited

Loading

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

nickoferrall commented Sep 17, 2024

mattkrick Sep 17, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 25, 2024

mattkrick Sep 27, 2024

nickoferrall Sep 30, 2024

mattkrick Sep 27, 2024

nickoferrall Sep 30, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

mattkrick Oct 1, 2024 •

edited

Loading

mattkrick left a comment

github-actions bot commented Oct 4, 2024

feat: refactor feature flags #10234

feat: refactor feature flags #10234

Conversation

nickoferrall commented Sep 16, 2024 • edited Loading

To test

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

nickoferrall commented Sep 17, 2024

mattkrick Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 25, 2024

mattkrick Sep 27, 2024

Choose a reason for hiding this comment

nickoferrall Sep 30, 2024

Choose a reason for hiding this comment

mattkrick Sep 27, 2024

Choose a reason for hiding this comment

nickoferrall Sep 30, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

mattkrick Oct 1, 2024 • edited Loading

Choose a reason for hiding this comment

mattkrick left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 4, 2024

nickoferrall commented Sep 16, 2024 •

edited

Loading

mattkrick Oct 1, 2024 •

edited

Loading