-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor feature flags #10234
Merged
nickoferrall
merged 31 commits into
feat/apply-new-feature-flag-mutation
from
feat/10099/feature-flag-refactor
Oct 4, 2024
Merged
feat: refactor feature flags #10234
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
85db00a
change featureFlagNew to featureFlag and replace org featureFlag
nickoferrall 92b0e8d
check zoomTranscription flag works
nickoferrall a7bd7ed
update org feature flags
nickoferrall 3fa2e08
refactor public teams flag
nickoferrall 333c456
add feature flag to org and team
nickoferrall 2059d00
refactor feature flags in client
nickoferrall 93e9cb4
implement dataloader
nickoferrall e3adf02
add featureFlag to team
nickoferrall 8a74299
update canAccessAISummary
nickoferrall 4d64131
remove update org feature flag
nickoferrall 17adb2b
remove update feature flag public mutation
nickoferrall c2c1b22
remove org and user feature flags
nickoferrall 7eba48b
remove featureFlag references
nickoferrall 4352f88
implement getFeatureFlags
nickoferrall d682ab1
implement get feature flags
nickoferrall 4b0d699
remove user and org feature flag enums
nickoferrall 2e335c7
merge with master
nickoferrall 8a4d5ba
fux setMeetingSettings merge conflict error
nickoferrall 0a40b4d
update migration order
nickoferrall e0b2dd9
Merge branch 'feat/apply-new-feature-flag-mutation' into feat/10099/f…
nickoferrall dfbf469
fix featureName
nickoferrall cb532b8
Merge branch 'feat/apply-new-feature-flag-mutation' into feat/10099/f…
nickoferrall 4b165c7
update featureFlag references to use scope
nickoferrall 39fa9e8
update addFeatureFlag to use scope
nickoferrall 4cf3339
remove scope from gql featureFlag query
nickoferrall 2e696de
fix ups - remove featureFlagScope graphql
nickoferrall e4190c3
use aliases consistently
nickoferrall df431b4
add getAllFeatureFlags private query
nickoferrall 03551b8
remove scope from dataloader
nickoferrall f5ee24c
remove scope from dataloader calls
nickoferrall 509f3a3
chore: migrate noaisummary flag (#10293)
nickoferrall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 nit on alias convention-- sometimes you have a suffix like
publicTeamsEnabled
, sometimes it's just the name of the featureaiTemplate
and here we have ahas
prefix. no right or wrong, but always nice to set a convention for others to followThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! I like the most explicit option of
has[name]Flag
, so I've updated all of them to follow that convention