Epic: 6.5 Sprint: Part1 Personal: MK

[mattkrick]

Team Dashboard | UserDashboard:

• does not shudder when you open a card menu like status for the first time (Shudder when clicking link urls #1255)
• does not shudder when you click a link & the link viewer modal opens for the first time (Shudder when clicking link urls #1255)
• when you go through the welcome wizard, one of the cards is now #private to show the difference
• create a new card, type "a " hit ctrl+k, add a link (foo, foo.co). notice that it says a foo instead of afoo
• has a placeholder for blank cards

Meeting Agenda:

• create a fresh team, start a meeting, create 1 agenda item, create a project for that agenda item, type something, try to convert it to a GitHub project by clicking the octocat.
• says No repos! Remind me to set up GitHub
• When you click it, it creates a #private card for you to remind you after the meeting

Team Settings > Integrations > GitHub

• If you add an integration, you get a "Creator" tag next to the repo name
• if you are a "creator" the option to link is disabled
• if the "creator" gets kicked off the team, their repos get removed & all repo cards get archived, even if others were still linked to it
• if the creator removes their GitHub token, the same as above happens
• if you add a personal github repo, a team member who is not a collaborator does not get added
• if you add a personal github repo, a team member who is a collaborator gets added
• if you add an org github repo, a team member who is not a member does not get added
• if you add an org github repo, a team member is a member gets added
• if you click link me, you get added if you are a collaborator/org member
• if you add a provider to an already existing github integration, you auto-join all repos that you are a collaborator/member of
• go to team dashboard, click the octocat on any card, go to team settings > integrations > github. click the dropdown. add a repo. no errors occur in the console (TypeError: Cannot read property 'includes' of undefined #1279)
• typing an array of emails delimited by , and/or ; does not break anything & still gives helpful hints on where they went wrong (semicolon delimitation on invites #1206)

/signout

• going to the signout route takes you back to the landing page & no errors show in the console
• the signout event is received by segment

/

• the User Login event is received by segment

/welcome

• all welcome wizard events are received by segment

[codecov]

Codecov Report

Merging #1265 into epic6.5 will increase coverage by 0.58%.
The diff coverage is 65.15%.

@@             Coverage Diff             @@
##           epic6.5    #1265      +/-   ##
===========================================
+ Coverage    54.61%   55.19%   +0.58%     
===========================================
  Files          147      148       +1     
  Lines         2124     2127       +3     
  Branches       301      303       +2     
===========================================
+ Hits          1160     1174      +14     
+ Misses         811      802       -9     
+ Partials       153      151       -2

Impacted Files	Coverage Δ
src/server/graphql/queries/integrationProvider.js	0% <ø> (ø)	⬆️
src/server/graphql/types/Provider.js	57.14% <ø> (ø)	⬆️
...ver/graphql/models/Team/notifySlack/notifySlack.js	28.57% <ø> (ø)	⬆️
src/universal/validation/makeProjectSchema.js	84.61% <ø> (ø)	⬆️
src/universal/redux/segmentActions.js	11.76% <ø> (+2.67%)	⬆️
src/server/graphql/queries/providerMap.js	5% <ø> (ø)	⬆️
src/server/utils/authorization.js	43.87% <ø> (-3.24%)	⬇️
src/client/Atmosphere.js	61.25% <0%> (-0.78%)	⬇️
src/server/graphql/types/GitHubIntegration.js	12.5% <0%> (-1.79%)	⬇️
...aphql/models/Organization/addBilling/addBilling.js	100% <100%> (ø)	⬆️
... and 18 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ece4778...e3475d9. Read the comment docs.

[mattkrick]

@jordanh ready for testing, i'll get to the linting in ~ 2 hours.

[mattkrick]

new relay doesn't need watchman

[mattkrick]

signing out might cause a rerender where this is null

[mattkrick]

eh, passed my tests. merging!