Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: other tabs break when accepting a team invitation via a link #7200

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

igorlesnenko
Copy link
Contributor

Fixes #4922

Testing scenarios

  • Scenario A

    • Open dashboard in one tab as User_1
    • As User_2 copy Team_2 invite link
    • As User_1 paste team invite link in a new tab
    • As User_1, on previously opened dashboard tab go to Tasks, see the app does not crash
  • Scenario B

    • Invite User_1 to the team via email
    • As User_1 click Accept on the appeared push notification
    • See all works fine
  • Scenario C

    • Invite User_1 to the team via email
    • Click on invite link in email
    • See all works fine

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@igorlesnenko igorlesnenko marked this pull request as ready for review September 19, 2022 14:57
Copy link
Contributor

@JimmyLv JimmyLv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting case, LGTM!

Copy link
Contributor

@Dschoordsch Dschoordsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested scenario 1 only

@igorlesnenko igorlesnenko merged commit d51ca5a into master Oct 7, 2022
@igorlesnenko igorlesnenko deleted the fix-invite-link-accept branch October 7, 2022 14:27
@github-actions github-actions bot mentioned this pull request Oct 11, 2022
JimmyLv added a commit that referenced this pull request Oct 12, 2022
* fix: other tabs break when accepting a team invitation via a link (#7200)

* fix(noImplicitAny): Fixup 200 ts rules (Part 2 of 2) (#7193)

* dx: begin client noImplicitAny

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* fix: 50 file checkpoint

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* remove getInProxy

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* finish all bugs in mutations dir

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* fix: finish remaining lint

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* turn on noImplicitAny for repo

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* address CR comments

Signed-off-by: Matt Krick <matt.krick@gmail.com>

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* chore: bootstrap release-release for automatic changelog & version changes (#7209)

* ci: bootstrap release-please

* ci: also add staging as the branch to trigger

* ci: add release-hotfix for production branch

* fix: don't include component in released Git tag

* fix: update the boostrap version & git hash

* fix: unsubscribe analytics bug (#7255)

* make subscribeToSummaryEmail an object in analytics

* second commit for pr rules

* update track type

* feat(metrics): Send isPatient0 property to Google Analytics (#7261)

* fix: participants follow facilitator (#7269)

Signed-off-by: Matt Krick <matt.krick@gmail.com>

Signed-off-by: Matt Krick <matt.krick@gmail.com>

* chore: release v6.78.0

Signed-off-by: Matt Krick <matt.krick@gmail.com>
Co-authored-by: Igor Lesnenko <igor.lesnenko@gmail.com>
Co-authored-by: Matt Krick <matt.krick@gmail.com>
Co-authored-by: JimmyLv_吕立青 <jimmy.jinglv@gmail.com>
Co-authored-by: Nick O'Ferrall <nickoferrall@gmail.com>
Co-authored-by: Bruce Tian <tianrunhe@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Oct 12, 2022
@JimmyLv JimmyLv mentioned this pull request Oct 12, 2022
20 tasks
This was referenced Oct 12, 2022
This was referenced Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Organization can be undefined in DashNavList
3 participants