fix: participants follow facilitator #7269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Krick <matt.krick@gmail.com>
|
@JimmyLv since we're so close to shipping the next release, could you please merge this in with the other PRs? If so, just change the base branch to staging. If we aren't going to ship in the next day, just let me know & we can merge this one separately. cc @Dschoordsch since we were chatting about this one |
JimmyLv
approved these changes
Oct 12, 2022
Merged
JimmyLv
added a commit
that referenced
this pull request
Oct 12, 2022
* fix: other tabs break when accepting a team invitation via a link (#7200) * fix(noImplicitAny): Fixup 200 ts rules (Part 2 of 2) (#7193) * dx: begin client noImplicitAny Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: 50 file checkpoint Signed-off-by: Matt Krick <matt.krick@gmail.com> * remove getInProxy Signed-off-by: Matt Krick <matt.krick@gmail.com> * finish all bugs in mutations dir Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: finish remaining lint Signed-off-by: Matt Krick <matt.krick@gmail.com> * turn on noImplicitAny for repo Signed-off-by: Matt Krick <matt.krick@gmail.com> * address CR comments Signed-off-by: Matt Krick <matt.krick@gmail.com> Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore: bootstrap release-release for automatic changelog & version changes (#7209) * ci: bootstrap release-please * ci: also add staging as the branch to trigger * ci: add release-hotfix for production branch * fix: don't include component in released Git tag * fix: update the boostrap version & git hash * fix: unsubscribe analytics bug (#7255) * make subscribeToSummaryEmail an object in analytics * second commit for pr rules * update track type * feat(metrics): Send isPatient0 property to Google Analytics (#7261) * fix: participants follow facilitator (#7269) Signed-off-by: Matt Krick <matt.krick@gmail.com> Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore: release v6.78.0 Signed-off-by: Matt Krick <matt.krick@gmail.com> Co-authored-by: Igor Lesnenko <igor.lesnenko@gmail.com> Co-authored-by: Matt Krick <matt.krick@gmail.com> Co-authored-by: JimmyLv_吕立青 <jimmy.jinglv@gmail.com> Co-authored-by: Nick O'Ferrall <nickoferrall@gmail.com> Co-authored-by: Bruce Tian <tianrunhe@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closed
This was referenced Oct 21, 2022
Closed
Closed
jmtaber129
added a commit
that referenced
this pull request
Feb 15, 2023
This reverts commit 1800d0f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7268
Reverts #7238
Demo
[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]
Testing scenarios