Signals cleanup project #18685
AffectedArc07
announced in
Projects
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This is long overdue, and is more of just a personal tracking discussion due to the scale of what needs to be done. Given this needs to be done in a very specific way, please run the details by me if you want to undertake part of it.
Currently ingame, we have this radio signal system, where devices are on radio channels and use that for communication. This is why updating status displays, summoning bots, changing vent controls and more takes an absolute age at times.
Not only is this system slow for the user, its incredibly bad code side, as when a device posts a signal, it has to loop over everything on the channel to decide if its intended for that signal or not. Its incredibly bad and a holdover from old code. Most of the CPU is wasted on self iteration logic which doesnt even achieve anything.
Reminder, 1000ms in a second, 20TPS = 50ms per tick, minus all the overhead for maptick
So yeah, this system is bad, and is still used by:
Also
/obj/machinery/embedded_controller
needs refactoring to not have program datums and stuff.This is the most useless pathtype and you cant tell me otherwise. They should just signal their airlocks with refs. Its not hard.
Will probably refactor those to use a mapping spawn helper which can link stuff to a door controller easily.
Beta Was this translation helpful? Give feedback.
All reactions