Refactors signallers, assemblies, electropacks #18689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AffectedArc07
added
Map Edit
ParadiseSS13-Bot
added
the
-Status: Awaiting review
AffectedArc07
commented
Aug 3, 2022
77 tasks
Sirryan2002
reviewed
Aug 4, 2022
Co-authored-by: Sirryan2002 <80364400+Sirryan2002@users.noreply.github.com>
hal9000PR
reviewed
Aug 14, 2022
ParadiseSS13-Bot
added
the
Testmerge Active
hal9000PR
approved these changes
Aug 14, 2022
ParadiseSS13-Bot
added
-Status: Awaiting merge
Co-authored-by: Charlie <69320440+hal9000PR@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AA Note
The amount of times I had to type
signalerinstead ofsignalleralmost killed me.What Does This PR Do
Part of #18685
Refactors signallers to use a global list instead of the radio signal awful system. This also meant refactoring electropacks, lightly refactoring the electric chair, as well as PDAs and PAIs to account for the new system. It also converts signallers to TGUI, that way I can re-use the UI for them.
I also ended up having to lightly refactor assemblies to make the examine text work, but I may as well fix it.
Why It's Good For The Game
I will kill this radio system. Its so badly designed and has so much overhead it may as well not exist.
Below is a list of things that should use this radio system:
This whole thing needs cleaning up, and I will do that. The performance gains and simplifications will be nice.
Testing
Changelog
🆑
add: Remote signallers now use TGUI
/:cl: