Players can no longer exploit Meteorshot to throw anything that's not a turf #17465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
197
to
199
| if(!M.anchored) | ||
| var/atom/throw_target = get_edge_target_turf(M, get_dir(src, get_step_away(M, src))) | ||
| M.throw_at(throw_target, 3, 2) |
There was a problem hiding this comment.
@Fox-McCloud
Im recalling a past incident where someone tried this and it had a bunch of adverse effects and we had to revert it.
I could be wrong though.
There was a problem hiding this comment.
alright, I've changed it over to move_resist since using anchored actively takes away from the intentions of meteorshot rather than just fixing the exploitive stuff
|
going to look into possibly using move_resist instead of this |
AffectedArc07
requested changes
Mar 6, 2022
AffectedArc07
added
Tweak
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Adds an additional
move_resist < INFINITYcheck to meteorshot to prevent anything thats not supposed to be immobile from being thrown around. This allows meteorshot to blow stuff off its anchor points but not critical things like cryodorm computers or shieldsWhy It's Good For The Game
Players should not have the ability to throw any seemingly immovable object off their hinges/anchors. Not to mention this will likely causes serious issues when knocking APCs, or even cryodorm equipment off their anchorpoints. Also has serious balance implications because all a nukie needs to get passed a reinforced vault door or shieldwall is a meteorshot or two
Changelog
🆑
fix: fixes an exploit with meteorshot
/:cl: