Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players can no longer exploit Meteorshot to throw anything that's not a turf #17465

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Players can no longer exploit Meteorshot to throw anything that's not a turf #17465

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c85c866
glorious fix
Sirryan2002 Mar 5, 2022
90288a8
moves check over to move_resist
Sirryan2002 Mar 6, 2022
f67cb7b
Update code/modules/projectiles/projectile/bullets.dm
Sirryan2002 Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions code/modules/projectiles/projectile/bullets.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,9 @@
..()
if(ismovable(target))
var/atom/movable/M = target
var/atom/throw_target = get_edge_target_turf(M, get_dir(src, get_step_away(M, src)))
M.throw_at(throw_target, 3, 2)
if(!M.anchored)
var/atom/throw_target = get_edge_target_turf(M, get_dir(src, get_step_away(M, src)))
M.throw_at(throw_target, 3, 2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fox-McCloud
Im recalling a past incident where someone tried this and it had a bunch of adverse effects and we had to revert it.

I could be wrong though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, I've changed it over to move_resist since using anchored actively takes away from the intentions of meteorshot rather than just fixing the exploitive stuff


/obj/item/projectile/bullet/meteorshot/New()
..()
Expand Down