Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Sanguine and Osseous Reagent #21148

Merged
merged 13 commits into from
Jul 11, 2023
Merged

Conversation

JimKil3
Copy link
Contributor

@JimKil3 JimKil3 commented May 21, 2023

What Does This PR Do

Progresses #20532 by implementing the reagents that would be used to fix internal bleeding and bone breaks. In the interest of atomicity (is that a word?) and because I believe these chemicals are interesting enough to be added on their own, they're being added in a separate PR.

Sanguine reagent, currently, restores blood quickly (up to about five times as fast as iron does), but has a risk of overdosing, causing brute and suffocation damage, so you can't just pump someone full of it and be done. It's made with the following:

  • 1u Omnizine
  • 2u Synthflesh
  • 2u Iron

Osseous reagent, currently, does minor toxin damage. However, with enough in your system (over 30 units), there's a chance that a bone tumor will form because of it, causing lethal damage to your lower body and the organs inside of it. The tumor requires surgery to be removed. While not a medicine, this should provide an interesting & effective alternate to normal poisons which can be countered with just pentetic acid or charcoal. It's made with the following:

  • 1u Milk
  • 1u Potassium
  • 4u Oxygen
  • 3u Phenol
  • 3u Formaldehyde

Of course, all of these numbers are subject to change if the balance or design teams find something too effective or weak.

Why It's Good For The Game

In addition to what they'd provide in the context of the cloning rework, both of these chemicals would benefit the game in their own ways. Sanguine reagent would give chemistry more options on what to do with their omnizine; should they make 90 pills of lazarus reagent, or split it between LR and (the new) SR? It also fills a niche of quick, but potentially risky, blood restoration.

Osseous reagent gives traitors or other antagonists a new option for poisoning that isn't countered by charcoal/pentetic acid/calomel. However, the high amount of osseous reagent required to form a bone tumor will need a new strategy than just syringe gunning / shotgun darting someone. On the medical side of things, it's a new, niche problem to deal with that requires surgery - though not a difficult one, as removing the bone tumor is just organ manipulation on the lower body.

Testing

Loaded in and drank things I probably shouldn't have, checking occasionally with a health analyzer.
Made a skrell donate blood, then gave it some sanguine reagent, periodically checking its blood level to make sure SR works.
Also made a skrell drink a lot of osseous reagent, then removed the tumor that formed as a result, after letting it damage the skrell.

Changelog

🆑
add: Added Sanguine Reagent, a potentially-risky way to restore blood quickly
add: Added Osseous Reagent, an insidious poison that requires surgery to treat properly
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label May 21, 2023
@Henri215 Henri215 added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label May 21, 2023
@farie82 farie82 added Balance This PR will modify how effective something is or isnt Feature This PR is a new addition to the game labels May 22, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels May 22, 2023
JimKil3 and others added 3 commits May 22, 2023 22:30
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jun 2, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Requested This PR has a pending testmerge request label Jun 18, 2023
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Jun 20, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label Jun 22, 2023
@Edan52
Copy link
Contributor

Edan52 commented Jun 29, 2023

I think the general consensus is to lower the blood restoration amount. Something stronger than iron but harder to make? Sure, but not five times stronger, might wanna lower it a bit.

@JimKil3
Copy link
Contributor Author

JimKil3 commented Jun 30, 2023

I think the general consensus is to lower the blood restoration amount. Something stronger than iron but harder to make? Sure, but not five times stronger, might wanna lower it a bit.

This is balanced, in my mind, by the fact that sanguine reagent takes omnizine to make; cutting from the total amount of lazarus reagent you'll be able to make, as well as cutting from how many IBs you'll be able to fix with the initial 30u of omnizine once the cloning rework is in.

If a decrease is still wanted despite that, I'm fine with doing it, just saying my reasoning. Are there any balance concerns with osseous reagent, or is that fine to leave as-is?

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Jul 4, 2023
@Vilshen
Copy link
Contributor

Vilshen commented Jul 5, 2023

Osseous seems just too slow to be useful.
Tumor takes forever to appear and then takes forever to actually kill the victim. And the toxic damage will cause them to still seek treatment, most likely purging osseous before the tumor forms.
I just don't see any situation where I'd use it over conventional poisons.

@CinnamonSnowball
Copy link
Contributor

I think the general consensus is to lower the blood restoration amount. Something stronger than iron but harder to make? Sure, but not five times stronger, might wanna lower it a bit.

Not sure where that "consensus" is coming from, but as far as Medbay is concerned, the amount of Sanguine Reagent you get (and thus how much blood you can recover) isn't super noteworthy, only enough for about 3-4 people; if anything, it's used best as an emergency tool for rare types of blood like Vox or Slime Jelly.

Outside of Medbay or if Chemistry wants to make more of it, you do have to go through the effort of finding a source of Omnizine, typically requiring interaction with someone to help you out - and in case of antags, additionally either a chemistry setup or some clever thievery - so not like it's more worth it than simply ordering a blood crate (which refills blood even faster)

@S34NW S34NW merged commit 083b74e into ParadiseSS13:master Jul 11, 2023
@JimKil3 JimKil3 deleted the cloning-reagents branch July 11, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Balance This PR will modify how effective something is or isnt Feature This PR is a new addition to the game Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Testmerge Active This PR is currently testmerged on production Testmerge Requested This PR has a pending testmerge request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants