-
Notifications
You must be signed in to change notification settings - Fork 168
Stabilize lazy evaluation of NEMO field data #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on paleo-plankton to verify fixes and develop a proper testing procedure
…o-bewritten, but existing tests already pass
…anParcels/parcels into stabilize_lazy_evaluation_NEMOfields
…and a NetCDF dimension (should be self.dataset.dimensions[name].size)
…rrors for Nemo data when using chunking
…h individual entry in files. That means that many files are opened multiple times simultaneously, leading to memory errors.
… example_nemo_curvilinear.py
…ld_chunksize and the acutallly used init_chunk_size
…er-defined field_chunksize for dicts of dicts
…ints ...' by also test the dask environment default (which is usually 128MiB)
…eo-plakton case
…listed in the used dimensions
…the North Sea NEMO
CKehl
added a commit
to CKehl/parcels
that referenced
this pull request
Mar 24, 2020
CKehl
added a commit
to CKehl/parcels
that referenced
this pull request
Mar 24, 2020
…s arising from an error in the NetCDFFileBuffer. Also cleared commented code where required and adapted formatting to the PEP8 linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lazy evaluation from Dask is still lacking robustness and some users still experience errors in some setups, which this PR attempts to resolve.