Stabilize dask loading of Ocean Model data #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on paleo-plankton to verify fixes and develop a proper testing procedure
…o-bewritten, but existing tests already pass
…anParcels/parcels into stabilize_lazy_evaluation_NEMOfields
…and a NetCDF dimension (should be self.dataset.dimensions[name].size)
…rrors for Nemo data when using chunking
…h individual entry in files. That means that many files are opened multiple times simultaneously, leading to memory errors.
… example_nemo_curvilinear.py
…ld_chunksize and the acutallly used init_chunk_size
…er-defined field_chunksize for dicts of dicts
…ints ...' by also test the dask environment default (which is usually 128MiB)
…eo-plakton case
…listed in the used dimensions
…the North Sea NEMO
…s arising from an error in the NetCDFFileBuffer. Also cleared commented code where required and adapted formatting to the PEP8 linter
…permanently-broken CI-chain.
CKehl
changed the title
…d to actually stop the search only if the filenames also match
…le but not requested py Parcels dimensions nor chunk sizes
Passes in scipy but breaks in jit
The rectilinear field works in both jit and scipy, but the curvilinear field only works in scipy
…s/parcels into stabilize_dask_field_loading
…tually also relevant to the requested data, in any 'field_chunksize' formulation
…nable test after #782 fix is thrown. Further adapted and fixed the chunking.
…he requested netcdf structure and the requested parcels dimensionality for each case of field_chunksize being False or None, auto, a tuple or a (dict of) dict(s). Now following with a clean-up.
…field() function. It's not ideal as NetCDF fields now need to run 3 times through essentially the same test, but in the current structure and with the required versatility, this is the way it works now. Tests are expanded and all run successfully locally.
Contributor
Author
|
The code runs all tests fine, but the test_palaeo_dataset.py still fails. |
CKehl
added a commit
that referenced
this pull request
Apr 3, 2020
CKehl
added a commit
to CKehl/parcels
that referenced
this pull request
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a clone or mirror of #774 , which suffers from a broken CI.
The lazy evaluation from Dask is still lacking robustness and some users still experience errors in some setups, which this PR attempts to resolve.
Test are developed for NEMO, GlobCurrent and POP.